FSx: Enable file_system_type_version property for LustreFileSystem construct #31130
Labels
@aws-cdk/aws-fsx
Related to Amazon FSx
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
LArkema
added
feature-request
ashishdhingra
added
p2
investigating
|
CfnFileSystem and AWS::FSx::FileSystem appear to support @LArkema Thanks for opening the issue. Feel free to contribute PR, if possible, that could be reviewed by the team. |
ashishdhingra
added
effort/small
1 task
|
this is bad, for instance RHEL 9.x is not compatible with version 2.10 |
mergify bot
pushed a commit
that referenced
this issue
Oct 16, 2024
#31136) ### Issue # (if applicable) Closes #31130 ### Reason for this change We cannot specify Lustre version for the file system. ### Description of changes Add `fileSystemTypeVersion` prop to `LustreFileSystemProps`. There are some restrictions about `fileSystemTypeVersion`. - 2.10 is supported by the Scratch and Persistent_1 Lustre deployment types. - 2.12 is supported by all Lustre deployment types, except for PERSISTENT_2 with a metadata configuration mode. - 2.15 is supported by all Lustre deployment types and is recommended for all new file systems. https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-fsx-filesystem.html#cfn-fsx-filesystem-filesystemtypeversion I've only added validation of V2.10 is supported by the Scratch and Persistent_1 deployment types because `LustreFileSystemProps` does not have metadata configuration props. ```ts private validateFiileSystemTypeVersion(deploymentType: LustreDeploymentType, fileSystemTypeVersion?: FileSystemTypeVersion): void { if (fileSystemTypeVersion === undefined) { return; } if (fileSystemTypeVersion === FileSystemTypeVersion.V_2_10) { if (!deploymentType.startsWith('SCRATCH') && deploymentType !== LustreDeploymentType.PERSISTENT_1) { throw new Error('fileSystemTypeVersion V_2_10 is only supported for SCRATCH and PERSISTENT_1 deployment types'); } } } ``` ### Description of how you validated changes Add both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
When creating a FSx Lustre File System with the fsx.LustreFileSystem() construct, users should be able to specify the File System Version just like they are able to do with the CloudFormation construct (using the
file_system_type_versionproperty). Currently, CDK creates a 2.10 File System, which lacks many core FSx features.At the very least, CDK should create the File System with the latest / recommended version. Per the CloudFormation docs "2.15 is supported by all Lustre deployment types and is recommended for all new file systems." Per the Getting Started docs, "All FSx for Lustre file systems are built on Lustre version 2.15 when created using the Amazon FSx console."
Use Case
When creating a FSx filesystem with CDK, I want to be able to use the latest version of the File System, not be stuck with version 2.10. While I can get around the problem by using the CfnFileSystem Resource, CDK is much preferred.
Proposed Solution
Add a property to the CDK construct that maps to the equivalent property for the CloudFormation 'file_system_type_version' property, and/or update the default Lustre version to 2.15
Other Information
No response
Acknowledgements
CDK version used
2.152.0
Environment details (OS name and version, etc.)
Various
The text was updated successfully, but these errors were encountered: