Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗ NOTICE(bedrock): AWS::Bedrock::DataSource L1 construct is missing DataSourceConfiguration property in latest version 2.154.0 #31183

Closed
1 task done
krokoko opened this issue Aug 22, 2024 · 5 comments Β· Fixed by cdklabs/awscdk-service-spec#1255
Labels
@aws-cdk/bedrock Related to @aws-cdk/bedrock aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. management/tracking Issues that track a subject or multiple issues p0 potential-regression Marking this issue as a potential regression to be checked by team member

Comments

@krokoko
Copy link

krokoko commented Aug 22, 2024

Please add your +1 πŸ‘ to let us know you have encountered this

Status:

RESOLVED
Fixed in version 2.154.1

Overview:

v2.154.0 removes DataSourceConfiguration property from AWS::Bedrock::DataSource resource L1 construct.

Workaround:

Downgrade to v2.153.0

Solution:

Upgrade to >= v2.154.1

Related Issues:

N/A


ORIGINAL ISSUE DESCRIPTION

Describe the bug

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_bedrock.CfnDataSource.html was updated with v2.154.0
However, it is missing a property which is available in cfn: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html
The property is DataSourceConfiguration. The property is listed in the header of the cdk documentation, but not available in the example, construct props.
This property was available in previous versions

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

2.153

Expected Behavior

The property is available

Current Behavior

The property is not available, which makes the construct unusable

Reproduction Steps

use the latest cdk version 2.154.0

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.154

Framework Version

No response

Node.js Version

20

OS

MacOs

Language

TypeScript, Python, .NET, Java, Go

Language Version

No response

Other information

No response

@krokoko krokoko added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 22, 2024
@github-actions github-actions bot added aws-cdk-lib Related to the aws-cdk-lib package potential-regression Marking this issue as a potential regression to be checked by team member labels Aug 22, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Aug 22, 2024

@ashishdhingra ashishdhingra added p0 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 22, 2024
@pahud
Copy link
Contributor

pahud commented Aug 22, 2024

confirmed a regression by checking bedrock.generated.d.ts:

CfnDataSourceProps in 2.154.0

export interface CfnDataSourceProps {
    /**
     * The data deletion policy for the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-datadeletionpolicy
     */
    readonly dataDeletionPolicy?: string;
    /**
     * The description of the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-description
     */
    readonly description?: string;
    /**
     * The unique identifier of the knowledge base to which the data source belongs.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-knowledgebaseid
     */
    readonly knowledgeBaseId: string;
    /**
     * The name of the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-name
     */
    readonly name: string;
    /**
     * Contains details about the configuration of the server-side encryption.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-serversideencryptionconfiguration
     */
    readonly serverSideEncryptionConfiguration?: cdk.IResolvable | CfnDataSource.ServerSideEncryptionConfigurationProperty;
    /**
     * Contains details about how to ingest the documents in the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-vectoringestionconfiguration
     */
    readonly vectorIngestionConfiguration?: cdk.IResolvable | CfnDataSource.VectorIngestionConfigurationProperty;
}

CfnDataSourceProps in 2.153.0

export interface CfnDataSourceProps {
    /**
     * The data deletion policy for the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-datadeletionpolicy
     */
    readonly dataDeletionPolicy?: string;
    /**
     * The connection configuration for the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-datasourceconfiguration
     */
    readonly dataSourceConfiguration: CfnDataSource.DataSourceConfigurationProperty | cdk.IResolvable;
    /**
     * The description of the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-description
     */
    readonly description?: string;
    /**
     * The unique identifier of the knowledge base to which the data source belongs.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-knowledgebaseid
     */
    readonly knowledgeBaseId: string;
    /**
     * The name of the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-name
     */
    readonly name: string;
    /**
     * Contains details about the configuration of the server-side encryption.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-serversideencryptionconfiguration
     */
    readonly serverSideEncryptionConfiguration?: cdk.IResolvable | CfnDataSource.ServerSideEncryptionConfigurationProperty;
    /**
     * Contains details about how to ingest the documents in the data source.
     *
     * @see http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-bedrock-datasource.html#cfn-bedrock-datasource-vectoringestionconfiguration
     */
    readonly vectorIngestionConfiguration?: cdk.IResolvable | CfnDataSource.VectorIngestionConfigurationProperty;
}

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
@GavinZZ GavinZZ reopened this Aug 22, 2024
@aws aws unlocked this conversation Aug 22, 2024
@GavinZZ GavinZZ changed the title (bedrock): cfndatasource lost a property in latest version 2.154.0 (bedrock): AWS::Bedrock::DataSource L1 construct is missing DataSourceConfiguration property in latest version 2.154.0 Aug 22, 2024
@GavinZZ GavinZZ added management/tracking Issues that track a subject or multiple issues @aws-cdk/bedrock Related to @aws-cdk/bedrock and removed potential-regression Marking this issue as a potential regression to be checked by team member labels Aug 22, 2024
@GavinZZ GavinZZ pinned this issue Aug 22, 2024
@GavinZZ GavinZZ changed the title (bedrock): AWS::Bedrock::DataSource L1 construct is missing DataSourceConfiguration property in latest version 2.154.0 ❗ NOTICE(bedrock): AWS::Bedrock::DataSource L1 construct is missing DataSourceConfiguration property in latest version 2.154.0 Aug 22, 2024
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Aug 22, 2024
GavinZZ added a commit to cdklabs/aws-cdk-notices that referenced this issue Aug 23, 2024
mergify bot pushed a commit to cdklabs/aws-cdk-notices that referenced this issue Aug 23, 2024
@krokoko
Copy link
Author

krokoko commented Aug 23, 2024

Thank you for the quick fix ! :)

@GavinZZ GavinZZ closed this as completed Aug 23, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@GavinZZ GavinZZ unpinned this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/bedrock Related to @aws-cdk/bedrock aws-cdk-lib Related to the aws-cdk-lib package bug This issue is a bug. management/tracking Issues that track a subject or multiple issues p0 potential-regression Marking this issue as a potential regression to be checked by team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants