Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2: Rename "Fleet" to AutoScalingGroup #313

Closed
eladb opened this issue Jul 11, 2018 · 1 comment · Fixed by #318
Closed

ec2: Rename "Fleet" to AutoScalingGroup #313

eladb opened this issue Jul 11, 2018 · 1 comment · Fixed by #318
Assignees
@RomainMuller

Comments

@eladb
Copy link
Contributor

eladb commented Jul 11, 2018

We should align to EC2 semantics
@PaulMaddox
Copy link
Contributor

+1. I was going to raise this but you beat me to it.

We have Spot Fleet and EC2 Fleet in AWS already so this is an overloaded term.

@RomainMuller RomainMuller self-assigned this Jul 11, 2018
RomainMuller added a commit that referenced this issue Jul 11, 2018
@RomainMuller
[BREAKING] Rename @aws-cdk/ec2.Fleet to AutoScalingGroup
f99bc28 
There are already several overloads in the AWS landscape for the word `Fleet`,
namely `Spot Fleet`, `EC2 Fleet`, ... We should avoid creating new overloads for
the term. Instead, use the "standard" EC2 semantics of `AutoScalingGroup`.

Fixes #313
@RomainMuller RomainMuller mentioned this issue Jul 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BREAKING] Rename @aws-cdk/ec2.Fleet to AutoScalingGroup aws/aws-cdk
3 participants
@RomainMuller @eladb @PaulMaddox