Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticLoadBalancingV2: Add Property To Enable Zonal Shift Support in L2 Construct #31983

Closed
1 of 2 tasks
hakenmt opened this issue Nov 1, 2024 · 3 comments · Fixed by #31990
Closed
1 of 2 tasks

ElasticLoadBalancingV2: Add Property To Enable Zonal Shift Support in L2 Construct #31983

hakenmt opened this issue Nov 1, 2024 · 3 comments · Fixed by #31990
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@hakenmt
Copy link

hakenmt commented Nov 1, 2024

Describe the feature

NLB attributes can only directly be set in the L1 construct. Exposing some of the standard ones, like enabling zonal shift, which requires opt-in, requires additionally calling SetAttribute or casting to the L1 construct and adding the key/value to the array of attributes.

Use Case

Exposing this as a top level property for an NLB helps make users aware they need to opt-in (which is a recent change of behavior) and makes doing so easy.

Proposed Solution

Add EnableZonalShift as a boolean value, defaulting to false in the NetworkLoadBalancer L2 construct.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.164.0

Environment details (OS name and version, etc.)

darwin
@hakenmt hakenmt added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Nov 1, 2024
@ashishdhingra ashishdhingra self-assigned this Nov 1, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2024
@ashishdhingra
Copy link
Contributor

Appears to be a valid feature request. Per AWS::ElasticLoadBalancingV2::LoadBalancer LoadBalancerAttribute, the attributes dns_record.client_routing_policy and zonal_shift.config.enabled are only available for Network Load Balancers. In NetworkLoadBalancer L2 construct, it exposes clientRoutingPolicy in NetworkLoadBalancerProps, which is used to set dns_record.client_routing_policy here. However, it doesn't expose any property (e.g. enableZonalShift) for setting zonal_shift.config.enabled attribute.

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 1, 2024
@ashishdhingra ashishdhingra removed their assignment Nov 1, 2024
@badmintoncryer badmintoncryer mentioned this issue Nov 2, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Nov 4, 2024
Closed
@mergify mergify bot closed this as completed in #31990 Nov 7, 2024
@mergify mergify bot closed this as completed in 497abdc Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Nov 13, 2024
@badmintoncryer
feat(elasticloadbalancingv2): enable zonal shift for network load bal…
e819a6e 
…ancer (aws#31990)

### Issue # (if applicable)

Closes aws#31983.

### Reason for this change

AWS CDK does not support for configuring zonal shift for a NLB.

### Description of changes

Add `zonalShift` prop to `NetworkLoadBalancerProps`

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticloadbalancingv2): enable zonal shift for network load balancer badmintoncryer/aws-cdk
2 participants
@hakenmt @ashishdhingra