Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: cdk deploy --all #3222

Closed
1 of 5 tasks
fulghum opened this issue Jul 5, 2019 · 5 comments · Fixed by #10745
Closed
1 of 5 tasks

feature: cdk deploy --all #3222

fulghum opened this issue Jul 5, 2019 · 5 comments · Fixed by #10745
Assignees
@shivlaks
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@fulghum
Copy link
Contributor

fulghum commented Jul 5, 2019

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.

  • What is the current behavior?
    The "cdk deploy" command recently stopped deploying all stacks by default, which was often a handy behavior. You can still pass glob patterns, like '*', to deploy all stacks, but it might be nice to also have an explicit "--all" flag you could pass. Low priority, since the glob behavior works for this use case, but I suspect many users would expect an explicit "--all" option to be supported in addition to the glob support.
@fulghum fulghum added the needs-triage This issue or PR still needs to be triaged. label Jul 5, 2019
@davidbarsky
Copy link

Based off discussions in Gitter, the accepted wildcard is:

cdk deploy "*"

@shivlaks shivlaks added feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Aug 29, 2019
@stephendwu
Copy link
Contributor

I'd like to take a stab at this. In the event that a user uses the --all flag, but they also provide stacks, should the CLI default to deploying all stacks or only deploy the provided stacks?

@shivlaks
Copy link
Contributor

shivlaks commented Dec 4, 2019

@stephendwu - I think it's also reasonable to just error and provide guidance to the user to provide one or the other (rather than guess the user's intent)

@shivlaks shivlaks added the effort/small Small work item – less than a day of effort label Feb 5, 2020
@shivlaks shivlaks added the p2 label Aug 7, 2020
@IsmaelMartinez IsmaelMartinez mentioned this issue Oct 6, 2020
Merged
@IsmaelMartinez
Copy link
Contributor

PR ready for review in #10745

@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 7, 2020
@mergify mergify bot closed this as completed in #10745 Oct 26, 2020
mergify bot pushed a commit that referenced this issue Oct 26, 2020
@IsmaelMartinez
feat(cli): --all flag to select all stacks (#10745)
bcd9d0a 
Adding the --all option to deploy all stacks.

`cdk deploy --all` 

This is an alias of `*`. The previous command does the same as the following one:

`cdk deploy '*'` 

Closes #3222

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): --all flag to select all stacks IsmaelMartinez/aws-cdk
6 participants
@fulghum @IsmaelMartinez @davidbarsky @SomayaB @shivlaks @stephendwu