-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EKS: AL2023 Nvidia instance type missing #32378
Comments
I'm not seeing an API endpoint to list all possible values, but the values you listed seem to match the CloudFormation documentation for
There is also a aws-cdk/packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts Lines 195 to 201 in fa55194
aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.ts Lines 251 to 259 in fa55194
|
@nmussy Thanks for your review. We need to update NodegroupAmiType enum as well. Community contributed PR is welcome. :) |
### Issue # (if applicable) Closes #32378 ### Reason for this change <!--What is the bug or use case behind this change?--> - Missing AL2023 AMI type ### Description of changes <!--What code changes did you make? Have you made any important design decisions?--> - Add missing AL2023 AMI type ### Description of how you validated changes <!--Have you added any unit tests and/or integration tests?--> Integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --------- Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
Comments on closed issues and PRs are hard for our team to see. |
Describe the bug
It seems that the GPU instances are missing AL2023 Nvidia and Neuron entries
aws-cdk/packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts
Lines 595 to 600 in bf77e51
are
Regression Issue
Last Known Working CDK Version
No response
Expected Behavior
All supported GPU instances are in the enumeration
https://aws.amazon.com/blogs/containers/amazon-eks-optimized-amazon-linux-2023-accelerated-amis-now-available/
Current Behavior
GPU instances are missing AL2023 Nvidia and Neuron entries
Reproduction Steps
See the enum
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.171.1 (build a95560c)
Framework Version
No response
Node.js Version
22
OS
Mac
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: