Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS: AL2023 Nvidia instance type missing #32378

Closed
1 task
markusl opened this issue Dec 4, 2024 · 3 comments · Fixed by #32418
Closed
1 task

EKS: AL2023 Nvidia instance type missing #32378

markusl opened this issue Dec 4, 2024 · 3 comments · Fixed by #32418
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@markusl
Copy link
Contributor

markusl commented Dec 4, 2024

Describe the bug

It seems that the GPU instances are missing AL2023 Nvidia and Neuron entries

const gpuAmiTypes: NodegroupAmiType[] = [
NodegroupAmiType.AL2_X86_64_GPU,
NodegroupAmiType.BOTTLEROCKET_X86_64_NVIDIA,
NodegroupAmiType.BOTTLEROCKET_ARM_64_NVIDIA,
];

are

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

All supported GPU instances are in the enumeration

https://aws.amazon.com/blogs/containers/amazon-eks-optimized-amazon-linux-2023-accelerated-amis-now-available/

image

Current Behavior

GPU instances are missing AL2023 Nvidia and Neuron entries

Reproduction Steps

See the enum

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.171.1 (build a95560c)

Framework Version

No response

Node.js Version

22

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

@markusl markusl added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 4, 2024
@nmussy
Copy link
Contributor

nmussy commented Dec 4, 2024

I'm not seeing an API endpoint to list all possible values, but the values you listed seem to match the CloudFormation documentation for Nodegroup#amiType:

  • 'AL2023_x86_64_NEURON'
  • 'AL2023_x86_64_NVIDIA'

There is also a 'CUSTOM' value missing from the NodegroupAmiType enum, but it doesn't seem to be needed to use launchTemplateSpec

/**
* The AMI type for your node group. If you explicitly specify the launchTemplate with custom AMI, do not specify this property, or
* the node group deployment will fail. In other cases, you will need to specify correct amiType for the nodegroup.
*
* @default - auto-determined from the instanceTypes property when launchTemplateSpec property is not specified
*/
readonly amiType?: NodegroupAmiType;

this.cluster.addNodegroupCapacity('extra-ng2', {
minSize: 1,
// reusing the default capacity nodegroup instance role when available
nodeRole: this.cluster.defaultNodegroup?.role || this.cluster.defaultCapacity?.role,
launchTemplateSpec: {
id: lt.ref,
version: lt.attrDefaultVersionNumber,
},
});

@ashishdhingra
Copy link
Contributor

@nmussy Thanks for your review. We need to update NodegroupAmiType enum as well. Community contributed PR is welcome. :)

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2024
GavinZZ pushed a commit that referenced this issue Dec 10, 2024
### Issue # (if applicable)

Closes #32378 

### Reason for this change

<!--What is the bug or use case behind this change?-->
- Missing AL2023 AMI type

### Description of changes

<!--What code changes did you make? Have you made any important design
decisions?-->
- Add missing AL2023 AMI type

### Description of how you validated changes

<!--Have you added any unit tests and/or integration tests?-->
Integration test

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

---------

Co-authored-by: Jimmy Gaussen <jimmy.gaussen@gmail.com>
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants