Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cdk-lib.aws_apigatewayv2: Missing DetailedMetricsEnabled option #33222

Closed
2 tasks
philmod-h opened this issue Jan 29, 2025 · 2 comments · Fixed by #33267
Closed
2 tasks

aws-cdk-lib.aws_apigatewayv2: Missing DetailedMetricsEnabled option #33222

philmod-h opened this issue Jan 29, 2025 · 2 comments · Fixed by #33267
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@philmod-h
Copy link

Describe the feature

It's not possible to enable DetailedMetricsEnabled with the L2 construct.

Use Case

Get detailed metrics with HttpApi.

Proposed Solution

No response

Other Information

const cfnStage = stage.node.defaultChild as apigateway.CfnStage;
cfnStage.addOverride('Properties.DefaultRouteSettings.DetailedMetricsEnabled', true);

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.165.0 (build 00f70f1)

Environment details (OS name and version, etc.)

macos
@philmod-h philmod-h added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2025
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Jan 29, 2025
@pahud
Copy link
Contributor

pahud commented Jan 29, 2025

Yes, welcome PRs to get it exposed to the L2 surface. Thank you.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2025
@github-actions github-actions bot mentioned this issue Feb 1, 2025
Closed
@phuhung273 phuhung273 mentioned this issue Feb 1, 2025
Merged
1 task
@mergify mergify bot closed this as completed in #33267 Feb 7, 2025
mergify bot pushed a commit that referenced this issue Feb 7, 2025
@phuhung273
feat(apigatewayv2): stage support detailedMetricsEnabled property (#…
0abcacf 
…33267)

### Issue # (if applicable)

Closes #33222

### Reason for this change


Missing detailedMetricsEnabled property

### Description of changes


Stage support `detailedMetricsEnabled` property

### Describe any new or updated permissions being added




### Description of how you validated changes


Unit + Integration test

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): stage support detailedMetricsEnabled property phuhung273/aws-cdk
2 participants
@pahud @philmod-h