Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(rds): Add support for replicationSourceIdentifier prop #33280

Closed
2 tasks
moltar opened this issue Feb 3, 2025 · 2 comments · Fixed by #33471
Closed
2 tasks

(rds): Add support for replicationSourceIdentifier prop #33280

moltar opened this issue Feb 3, 2025 · 2 comments · Fixed by #33471
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@moltar
Copy link
Contributor

moltar commented Feb 3, 2025

Describe the feature

Docs: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraPostgreSQL.Migrating.RDSPostgreSQL.Replica.html

CF docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbcluster.html#aws-resource-rds-dbcluster-properties

This prop is available on the CfnDBCluster.

Use Case

Migrating RDS types, need to set this prop.

Proposed Solution

The DatabaseCluster class, should accept replicationInstanceSource prop, which accepts IDatabaseInstance:

replicationInstanceSource: IDatabaseInstance

Other Information

  • Cannot set masterUserPassword and masterUsername (CDK sets defaults) internally.
  • The value of replicationSourceIdentifier is NOT an identifier, but a full ARN.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

N/A

Environment details (OS name and version, etc.)

N/A
@moltar moltar added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 3, 2025
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Feb 3, 2025
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 3, 2025
@khushail khushail self-assigned this Feb 3, 2025
@khushail
Copy link
Contributor

khushail commented Feb 4, 2025 •
edited
Loading

Thanks @moltar for requesting this feature. Its evident from CDK docs that this prop is supported in Cloudformation -https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.CfnDBCluster.html#replicationsourceidentifier, hence can be supported via CDK too.

Marking it as P2 as the workaround of using L1 Construct already exists. Contributions from the community are also welcome.

@khushail khushail added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Feb 4, 2025
@khushail khushail removed their assignment Feb 4, 2025
@phuhung273 phuhung273 mentioned this issue Feb 16, 2025
Merged
1 task
@github-actions github-actions bot mentioned this issue Mar 1, 2025
Open
mergify bot pushed a commit that referenced this issue Mar 3, 2025
@phuhung273
feat(rds): DatabaseCluster support replicationSourceIdentifier (#…
878ad54 
…33471)

### Issue # (if applicable)

Closes #33280

### Description of changes

- `DatabaseCluster` support `replicationSourceIdentifier`
- Validate `replicationSourceIdentifier` cannot be used with `credentials`

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mergify mergify bot closed this as completed in #33471 Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): DatabaseCluster support replicationSourceIdentifier phuhung273/aws-cdk
2 participants
@moltar @khushail