Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit markers #33286

Closed
6 tasks done
mrgrain opened this issue Feb 4, 2025 · 1 comment · Fixed by aws/aws-cdk-cli#219
Closed
6 tasks done

Emit markers #33286

mrgrain opened this issue Feb 4, 2025 · 1 comment · Fixed by aws/aws-cdk-cli#219
Assignees
@mrgrain
Labels
@aws-cdk/toolkit p2

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Feb 4, 2025 •
edited
Loading

Emit markers (start/complete) during all actions as trace:

  • synth
  • deploy
  • destroy
  • asset publishing
  • rollback
  • bootstrap

These events should have unique codes
@github-actions github-actions bot mentioned this issue Mar 1, 2025
Open
@mrgrain mrgrain self-assigned this Mar 10, 2025
@mrgrain mrgrain mentioned this issue Mar 10, 2025
Merged
github-merge-queue bot pushed a commit to aws/aws-cdk-cli that referenced this issue Mar 11, 2025
@mrgrain
feat(toolkit-lib): emit marker messages during actions (#219)
84d0b54 
Introduces the new concept of "Message Spans" to connect multiple
messages for toolkit sub-tasks like "synth" or "build-assets" together.
A span consists of a number of messages that have the same `span` value.

At a minimum, a span is a pair of a `start` and an `end` message. Every
end message also reports the elapsed time since the start of the span.

Message spans will allow integrators to more easily track the flow of
"tasks" completed in the Toolkit.

## Changes

- Refactors the previous `Timer` class to "Message Spans"
- Introduces a new registry for spans at the bottom of the existing
messages registry. A span consists of a start and an end message maker.
- This PR makes use of the new `IoHelper` to provide a nicer API
- There is some more of type magic to ensure correct payloads, I don't
think this can be tested further
- I also changed the message registry to be private again, we are not
ready to have it as part of the public interface (this doesn't affect
our packages)
- Made some improvements to the bundling of declaration files. It's
currently really slow because it ends up scanning through A LOT of SDK
types. Will look into this more in a follow-up PR.

Fixes aws/aws-cdk#33286

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrgrain mrgrain

Labels
@aws-cdk/toolkit p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toolkit-lib): emit marker messages during actions aws/aws-cdk-cli
1 participant
@mrgrain