Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python dependency libraries are set to latest #3517

Closed
1 of 5 tasks
lkoniecz opened this issue Aug 2, 2019 · 8 comments
Closed
1 of 5 tasks

Python dependency libraries are set to latest #3517

lkoniecz opened this issue Aug 2, 2019 · 8 comments
Assignees
Labels
bug This issue is a bug. in-progress This issue is being actively worked on. language/python Related to Python bindings p1

Comments

@lkoniecz
Copy link

lkoniecz commented Aug 2, 2019

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.
  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
    Following requirements set

aws-cdk.core==1.0.0
aws-cdk.aws_ec2==1.0.0
aws-cdk.aws_eks==1.0.0
aws-cdk.aws_autoscaling==1.0.0
aws-cdk.aws_elasticloadbalancing==1.0.0
aws-cdk.aws_dynamodb==1.0.0
aws-cdk.aws_lambda==1.0.0
aws-cdk.aws_iam==1.0.0
aws-cdk.aws_apigateway==1.0.0

installs

aws-cdk.assets                     1.2.0     
aws-cdk.aws-apigateway             1.0.0     
aws-cdk.aws-applicationautoscaling 1.2.0     
aws-cdk.aws-autoscaling            1.0.0     
aws-cdk.aws-autoscaling-common     1.2.0     
aws-cdk.aws-certificatemanager     1.2.0     
aws-cdk.aws-cloudformation         1.2.0     
aws-cdk.aws-cloudwatch             1.2.0     
aws-cdk.aws-dynamodb               1.0.0     
aws-cdk.aws-ec2                    1.0.0     
aws-cdk.aws-eks                    1.0.0     
aws-cdk.aws-elasticloadbalancing   1.0.0     
aws-cdk.aws-elasticloadbalancingv2 1.2.0     
aws-cdk.aws-events                 1.2.0     
aws-cdk.aws-iam                    1.0.0     
aws-cdk.aws-kms                    1.2.0     
aws-cdk.aws-lambda                 1.0.0     
aws-cdk.aws-logs                   1.2.0     
aws-cdk.aws-route53                1.2.0     
aws-cdk.aws-s3                     1.2.0     
aws-cdk.aws-s3-assets              1.2.0     
aws-cdk.aws-sns                    1.2.0     
aws-cdk.aws-sqs                    1.2.0     
aws-cdk.aws-ssm                    1.0.0     
aws-cdk.core                       1.0.0     
aws-cdk.cx-api                     1.2.0     
aws-cdk.region-info                1.2.0  

Transitive dependencies are always resolved to latest which leads to errors - this one, for instance:

(.env) [eba@INV-7947 eks]$ cdk ls
Traceback (most recent call last):
  File "app.py", line 3, in <module>
    from aws_cdk import (
  File "/home/eba/work/cfconfig/contrib/cloudformation/cdk/eks/.env/lib/python3.7/site-packages/aws_cdk/aws_ec2/__init__.py", line 14, in <module>
    import aws_cdk.aws_ssm
  File "/home/eba/work/cfconfig/contrib/cloudformation/cdk/eks/.env/lib/python3.7/site-packages/aws_cdk/aws_ssm/__init__.py", line 16, in <module>
    class CfnAssociation(aws_cdk.core.CfnResource, metaclass=jsii.JSIIMeta, jsii_type="@aws-cdk/aws-ssm.CfnAssociation"):
  File "/home/eba/work/cfconfig/contrib/cloudformation/cdk/eks/.env/lib/python3.7/site-packages/aws_cdk/aws_ssm/__init__.py", line 228, in CfnAssociation
    @jsii.data_type(jsii_type="@aws-cdk/aws-ssm.CfnAssociation.InstanceAssociationOutputLocationProperty", jsii_struct_bases=[])
TypeError: data_type() missing 1 required keyword-only argument: 'name_mapping'
  • What is the expected behavior (or behavior of feature suggested)?
    Libraries install their dependencies with the same version.

  • What is the motivation / use case for changing the behavior or adding this feature?
    Whole library set becomes unstable and does not work.

  • Please tell us about your environment:

    • CDK CLI Version: 1.0.0
    • Module Version: 1.0.0
    • OS: [all]
    • Language: [Python]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

@lkoniecz lkoniecz added the needs-triage This issue or PR still needs to be triaged. label Aug 2, 2019
@vaneek
Copy link

vaneek commented Aug 2, 2019

I have also notice odd behavior, currently I am at CDK 1.2.0 but the modules all show 1.0.0.

CDKMetadata:
    Type: AWS::CDK::Metadata
    Properties:
      Modules: aws-cdk=1.2.0,
                      @aws-cdk/assets=1.0.0,
                      @aws-cdk/aws-autoscaling=1.0.0,
                      @aws-cdk/aws-autoscaling-common=1.0.0,
                      @aws-cdk/aws-certificatemanager=1.0.0,
                      @aws-cdk/aws-cloudformation=1.0.0,
                      @aws-cdk/aws-cloudwatch=1.0.0,
                      @aws-cdk/aws-codecommit=1.0.0, 
                      @aws-cdk/aws-ec2=1.0.0,
                      @aws-cdk/aws-elasticloadbalancing=1.0.0,
                      @aws-cdk/aws-elasticloadbalancingv2=1.0.0,
                      @aws-cdk/aws-events=1.0.0,
                      @aws-cdk/aws-iam=1.0.0,
                      @aws-cdk/aws-kms=1.0.0,
                      @aws-cdk/aws-lambda=1.0.0,
                      @aws-cdk/aws-logs=1.0.0,
                      @aws-cdk/aws-route53=1.0.0,
                      @aws-cdk/aws-s3=1.0.0,
                      @aws-cdk/aws-s3-assets=1.0.0,
                      @aws-cdk/aws-sns=1.0.0,
                      @aws-cdk/aws-sns-subscriptions=1.0.0,
                      @aws-cdk/aws-sqs=1.0.0,
                      @aws-cdk/aws-ssm=1.0.0,
                      @aws-cdk/core=1.0.0,
                      @aws-cdk/cx-api=1.0.0,
                      @aws-cdk/region-info=1.0.0,
                      jsii-runtime=Python/3.6.8

I tried to force the modules to 1.2.0 but I only made a mess of things. There is also inconsistency with the latest JSII version as well.

@RomainMuller RomainMuller added the language/python Related to Python bindings label Aug 2, 2019
@garnaat garnaat self-assigned this Aug 6, 2019
@SomayaB SomayaB added bug This issue is a bug. in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2019
@eladb eladb assigned RomainMuller and unassigned garnaat Nov 4, 2019
@RomainMuller RomainMuller added the p1 label Nov 5, 2019
@MrArnoldPalmer
Copy link
Contributor

See aws/jsii#676 for more information.

@lkoniecz
Copy link
Author

@MrArnoldPalmer any updates on this?

@MrArnoldPalmer
Copy link
Contributor

@lkoniecz I thought this was addressed with aws/jsii#1141. Are you still experiencing issues?

@lkoniecz
Copy link
Author

@MrArnoldPalmer
I tried that on 1.18 which still installs 1.20 python dependecies.

@henrist
Copy link

henrist commented Jan 21, 2020

The fix was released in jsii 0.21.0, which is used since cdk 1.20.0 (#5610). You will need to update to 1.20.0 or later for the dependencies to resolve correctly. This issue should be closed.

@lkoniecz
Copy link
Author

lkoniecz commented Jan 21, 2020

@henrist
Thanks, this explains the reason why I still see the problem.

@MrArnoldPalmer
Copy link
Contributor

Closing this fixed/dupe.

See #676 and aws/jsii#1141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. in-progress This issue is being actively worked on. language/python Related to Python bindings p1
Projects
None yet
Development

No branches or pull requests

7 participants