Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI dependencies are set to latest #3768

Closed
stefanolczak opened this issue Aug 23, 2019 · 4 comments
Closed

CLI dependencies are set to latest #3768

stefanolczak opened this issue Aug 23, 2019 · 4 comments
Assignees
Labels
bug This issue is a bug. p1

Comments

@stefanolczak
Copy link

🐛 Bug Report

What is the problem?

We are trying to force CDK CLI version by using package.json file on repository that looks like that:

{
  "dependencies": {
    "aws-cdk": "1.4.0"
  }
}

We thought it is sufficient to force CDK CLI version to specified one but with release of CDK 1.5.0 we realised it is not. The problem is that aws-cdk module has some dependencies ( @aws-cdk/cloudformation-diff, @aws-cdk/cx-api, @aws-cdk/region-info ) marked as >= 1.4.0 which will result in installing them with 1.5.0 version which is not compatible with 1.4.0. Also one of the dependencies ( @aws-cdk/cloudformation-diff ) has dependency @aws-cdk/cfnspec marked as >= 1.4.0. I guess its better to mark the dependencies to match the version of aws-cdk module instead of allowing to install latest ones.

Reproduction Steps

  1. Create package.json file mentioned here.
  2. Run: npm install
  3. Try to synth any CDK app.
  4. Notice that there are errors like that:
jsii.errors.JavaScriptError: 
  TypeError: builder.build is not a function
      at Function.synth (/tmp/jsii-kernel-sVWgHJ/node_modules/@aws-cdk/core/lib/construct.js:74:24)
      at App.synth (/tmp/jsii-kernel-sVWgHJ/node_modules/@aws-cdk/core/lib/app.js:67:52)

Environment

  • CDK CLI Version: 1.4.0
  • OS: all
  • Language: all
@stefanolczak stefanolczak added the bug This issue is a bug. label Aug 23, 2019
@nija-at
Copy link
Contributor

nija-at commented Aug 23, 2019

Related issue #3517

@skinny85
Copy link
Contributor

Related issue: #3711.

@shuynh
Copy link

shuynh commented Aug 29, 2019

running into this problem also! it's currently breaking our CI pipeline for review apps :(

@RomainMuller RomainMuller assigned shivlaks and unassigned RomainMuller Nov 4, 2019
@shivlaks shivlaks added the p1 label Nov 14, 2019
@shivlaks
Copy link
Contributor

resolving this as fixed - see aws/jsii#1141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1
Projects
None yet
Development

No branches or pull requests

7 participants