Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALB: New types of listener rule conditions #3888

Closed
1 of 2 tasks
KnisterPeter opened this issue Aug 30, 2019 · 3 comments · Fixed by #7848
Closed
1 of 2 tasks

ALB: New types of listener rule conditions #3888

KnisterPeter opened this issue Aug 30, 2019 · 3 comments · Fixed by #7848
Assignees
@rix0rrr
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.

Comments

@KnisterPeter
Copy link
Contributor

🚀 Feature Request

Add listener rules to ALB

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

This should contain the posibilities to add rules based on different conditions.
Right now there is support for path and header and at least one is required.
It should be possible to allow on query, source-ip, request method as well

(https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-listenerrule-conditions.html)

Proposed Solution

Not sure if this requires a breaking change or if it could be added with just new API.

Environment

  • CDK CLI Version:
  • Module Version:
  • OS:
  • Language:

Other information
@KnisterPeter KnisterPeter added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2019
@SomayaB SomayaB added the @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing label Sep 3, 2019
@rix0rrr rix0rrr removed the needs-triage This issue or PR still needs to be triaged. label Sep 4, 2019
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jan 23, 2020
@rix0rrr rix0rrr changed the title Add listener rules to ALB ALB: New types of listener rule conditions Jan 23, 2020
@michaelbrewer
Copy link
Contributor

This is related to issue : #5739

@rzamana
Copy link
Contributor

rzamana commented Feb 14, 2020

@rix0rrr
I decided to take a look at this issue to help fix it! But I don't agree with the labels "good first use" and "effort/small".

Today, the ApplicationListenerRule is ready to work including the values for host-header and path-pattern in the Values field. To create the other conditions we need to move to the new concept in the CloudFormation documentation, and start using the specific fields ('HostHeaderConfig', 'PathPatternConfig' and so on). So this requires more effort than first imagined!

@jverhoeks
Copy link

Currently hostHeader and pathPattern only support a single string. They conversion to array is done directly here: https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-listener-rule.ts#L196

Would be nice to have it support also multiple hostHeaders

@karupanerura karupanerura mentioned this issue May 1, 2020
Closed
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label May 5, 2020
@karupanerura karupanerura mentioned this issue May 7, 2020
Merged
@SomayaB SomayaB added @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 and removed @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing labels May 11, 2020
@mergify mergify bot closed this as completed in #7848 May 21, 2020
mergify bot pushed a commit that referenced this issue May 21, 2020
@karupanerura
feat(elbv2): Supports new types of listener rule conditions (#7848)
3d30ffa 
### Commit Message
feat(elbv2): Supports new types of listener rule conditions

Fixes #3888
### End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
6 participants
@rzamana @KnisterPeter @rix0rrr @jverhoeks @michaelbrewer @SomayaB