Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromTableName and fromTableArn #3895

Closed
1 of 2 tasks
rhboyd opened this issue Sep 1, 2019 · 6 comments · Fixed by #5280
Closed
1 of 2 tasks

fromTableName and fromTableArn #3895

rhboyd opened this issue Sep 1, 2019 · 6 comments · Fixed by #5280
Assignees
@skinny85
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@rhboyd
Copy link
Contributor

rhboyd commented Sep 1, 2019 •
edited by SomayaB
Loading

🚀 Feature Request

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

The DynamoDB Table Construct should support two static methods fromTableName and fromTableArn to create Table objects so that grant*() methods can be used to give Lambda Functions permissions to CRUD the Table.

Proposed Solution

Ctrl + C / Ctrl + V from maybe S3 Buckets.

Environment

  • CDK CLI Version:
  • Module Version:
  • OS: all
  • Language: all

Other information
@rhboyd rhboyd added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 1, 2019
@skinny85 skinny85 self-assigned this Sep 2, 2019
@jatsrt
Copy link

jatsrt commented Sep 22, 2019

Another use case is subscribing a lambda function to an existing(defined elsewhere) table stream.

@SomayaB SomayaB added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Oct 1, 2019
@NGL321 NGL321 removed the needs-triage This issue or PR still needs to be triaged. label Oct 14, 2019
@NGL321
Copy link
Contributor

NGL321 commented Oct 14, 2019

@rhboyd,

Sorry for the long delay. This seems like a totally reasonable add!

😸

@jogold jogold mentioned this issue Oct 30, 2019
Closed
2 tasks
@gauravj116
Copy link

Is it possible to do this using any lower level APIs?

@Pinny3
Copy link

Pinny3 commented Nov 2, 2019

Any news for that? Need it desperately....

@zxkane
Copy link
Contributor

zxkane commented Nov 19, 2019

Any progress on it? Might I contribute PR for it.

@skinny85
Copy link
Contributor

Go ahead @zxkane .

zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 3, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
010e66d 
Closes aws#3895.
@zxkane zxkane mentioned this issue Dec 3, 2019
Merged
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 3, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
3b3fa61 
Closes aws#3895.
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 3, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
4164f32 
Closes aws#3895.
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 3, 2019
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 18, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
aac9b18 
Closes aws#3895.
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 18, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
90b82f3 
Closes aws#3895.
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 18, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
4786670 
Closes aws#3895.
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 24, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
d59d646 
Closes aws#3895.
zxkane added a commit to zxkane/aws-cdk that referenced this issue Dec 24, 2019
@zxkane
feat(dynamodb): Implement importing existing dynamodb table.
05448d5 
Closes aws#3895.
@mergify mergify bot closed this as completed in #5280 Dec 26, 2019
mergify bot added a commit that referenced this issue Dec 26, 2019
@zxkane @mergify
feat(dynamodb): Implement importing existing dynamodb table. (#5280)
8d9b58b 
Closes #3895.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dynamodb): Implement importing existing dynamodb table. zxkane/aws-cdk
8 participants
@skinny85 @jatsrt @zxkane @Pinny3 @NGL321 @gauravj116 @SomayaB @rhboyd