Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions): add support for Map state #4145

Merged
merged 5 commits into from
Oct 4, 2019
Merged

feat(stepfunctions): add support for Map state #4145

merged 5 commits into from
Oct 4, 2019

Conversation

melalawi
Copy link

@melalawi melalawi commented Sep 18, 2019 •
edited
Loading

Today, Step Functions launched Map states. This PR adds support for this new state type in CDK.

https://aws.amazon.com/about-aws/whats-new/2019/09/aws-step-functions-adds-support-for-dynamic-parallelism-in-workflows/

https://docs.aws.amazon.com/step-functions/latest/dg/amazon-states-language-map-state.html

:)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@melalawi melalawi requested a review from eladb as a code owner September 18, 2019 21:06
@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@melalawi melalawi changed the title AWS Step Functions: Add support for Map state, add test for Parallel state. add support for map state, add test for parallel state. Sep 18, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@melalawi melalawi changed the title add support for map state, add test for parallel state. feat: support for map state, add test for parallel state. Sep 19, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr self-assigned this Sep 19, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 20, 2019 •
edited
Loading

Duplicate: #4153

Will need some time to go over both and compare.

@rix0rrr rix0rrr mentioned this pull request Sep 20, 2019
Closed
rix0rrr
rix0rrr reviewed Sep 20, 2019
View reviewed changes
packages/@aws-cdk/aws-stepfunctions/lib/states/map.ts Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions/lib/states/map.ts Outdated
*
* @default false
*/
readonly sequential?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather have the number here, no?

Copy link
Author

@melalawi melalawi Sep 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This is a remnant of the beta version of map state! :)

I'll update it to an unsigned integer.

@rhboyd
Copy link
Contributor

rhboyd commented Sep 24, 2019

I’m okay abandoning my PR in favor of @melalawi’s so we’re not duplicating work.

@yyolk yyolk mentioned this pull request Sep 24, 2019
Closed
2 tasks
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 30, 2019

We need someone to carry this to the finish line :)

@yyolk
Copy link

yyolk commented Oct 3, 2019 •
edited
Loading

Would I be able to use this branch as-is to generate the subsequent python dependency with the docker image?

Right now my stack is in python and I've only tried building this repo once (it worked, Jsii is pretty neat. The stack works as declared too)

I've only been installing from pip&npm, so I'll at the very least be building this to see if it works for my needs - I can also report back if that helps get this merged?

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Oct 4, 2019
rix0rrr
rix0rrr previously approved these changes Oct 4, 2019
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed rix0rrr’s stale review October 4, 2019 10:25

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title feat: support for map state, add test for parallel state. feat: add support for Map state Oct 4, 2019
@rix0rrr rix0rrr changed the title feat: add support for Map state feat(stepfunctions): add support for Map state Oct 4, 2019
@rix0rrr rix0rrr merged commit c8f0bcf into aws:master Oct 4, 2019
@yyolk
Copy link

yyolk commented Oct 4, 2019

w00t!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr left review comments

@eladb eladb Awaiting requested review from eladb

Assignees

@rix0rrr rix0rrr

Labels
pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@melalawi @aws-cdk-automation @rix0rrr @rhboyd @yyolk