Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP DO NOT MERGE StepFunctions Dynamic Parallelism #4153

Closed
wants to merge 1 commit into from
Closed

WIP DO NOT MERGE StepFunctions Dynamic Parallelism #4153

wants to merge 1 commit into from

Conversation

rhboyd
Copy link
Contributor

@rhboyd rhboyd commented Sep 19, 2019

would like to get some early feedback

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rhboyd rhboyd requested a review from eladb as a code owner September 19, 2019 03:16
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rhboyd rhboyd mentioned this pull request Sep 19, 2019
Closed
2 tasks
@RomainMuller
Copy link
Contributor

RomainMuller commented Sep 19, 2019 •
edited
Loading

@rhboyd - you might be interested to learn that GitHub now supports submitting "WIP" PR's as a first-class concept, so they cannot be merged before you "convert out to regular PR". 😬

@rix0rrr rix0rrr self-assigned this Sep 19, 2019
@rhboyd
Copy link
Contributor Author

rhboyd commented Sep 19, 2019

That’s great to hear. I didn’t now that.

@SomayaB SomayaB mentioned this pull request Sep 19, 2019
Closed
2 tasks
@rix0rrr rix0rrr mentioned this pull request Sep 20, 2019
Merged
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 20, 2019

Duplicate: #4145

Will need some time to go over both and compare.

rix0rrr
rix0rrr reviewed Sep 20, 2019
View reviewed changes
packages/@aws-cdk/aws-stepfunctions/lib/states/map.ts
/**
* Define one or more graphs to run in map
*/
public dynamicBranch(graph: IChainable): Map {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it iterator like in the official service docs?

rix0rrr
rix0rrr reviewed Sep 20, 2019
View reviewed changes
packages/@aws-cdk/aws-stepfunctions/lib/states/map.ts
* Usually, State Properties are contained in the state.ts file, but maxConcurrency
* only exists in this one state (for now).
*/
protected readonly maxConcurrency: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not get set, does it?

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 25, 2019

Closing in favor of #4145

Thanks for the enthusiasm!

@rix0rrr rix0rrr closed this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr left review comments

@eladb eladb Awaiting requested review from eladb

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhboyd @aws-cdk-automation @RomainMuller @rix0rrr @boydrh