DockerImageAsset: exclude option is ignored

[kuwabarahiroshi]

DockerImageAsset is documented that it has exclude? property.

Then, I specified my image such as below:

const image = new DockerImageAsset(this, 'MyProjectImage', {
  directory: path.join(__dirname, '..', '..'),
  repositoryName: 'my-project',
  exclude: ['cdk', 'node_modules', 'tmp', 'log', 'storage', 'vendor']
});

It worked until v1.9.0, but the property is ignored since v1.10.0.

I found 8389eeb is just overriding the exclude property.

Workaround is to list those files into .dockerignore. But .dockerignore and exclude option behaves a little different.

Reproduction Steps

const image = new DockerImageAsset(this, 'MyProjectImage', {
  directory: '.',
  repositoryName: 'my-project',
  exclude: ['cdk', 'node_modules', 'tmp', 'log', 'storage', 'vendor']
});

cdk.out shouldn't include those files listed in exclude option.

Environment

• CLI Version : >= v1.10.0
• Framework Version:
• OS : Mac OSX 10.14.5
• Language : TypeScript

Other

I just wanted to avoid this issue: #3899

---

This is 🐛 Bug Report

[NGL321]

Hey @kuwabarahiroshi!

Thank you so much for contributing. This issue should be closed out once your PR is merged.