Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IGrantable on aws-custom-resource/AwsCustomResource #4710

Closed
1 of 2 tasks
abelmokadem opened this issue Oct 28, 2019 · 3 comments · Fixed by #4790
Closed
1 of 2 tasks

Implement IGrantable on aws-custom-resource/AwsCustomResource #4710

abelmokadem opened this issue Oct 28, 2019 · 3 comments · Fixed by #4790
Assignees
@eladb
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@abelmokadem
Copy link
Contributor

Implement IGrantable on aws-custom-resource/AwsCustomResource.

Use Case

I need to allow passRole for the creation of a custom resource.

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@abelmokadem abelmokadem added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2019
@SomayaB SomayaB added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Oct 28, 2019
@jogold
Copy link
Contributor

jogold commented Oct 29, 2019

In the meantime you can use the policyStatements prop.

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Oct 30, 2019
@SomayaB
Copy link
Contributor

SomayaB commented Oct 30, 2019

Hi @abelmokadem, thanks for submitting a feature request! We will look into this and someone will update this issue when there is movement.

jogold added a commit to jogold/aws-cdk that referenced this issue Oct 31, 2019
@jogold
feat(custom-resources): implement IGrantable for AwsCustomResource
eae6375 
Closes aws#4710
@jogold jogold mentioned this issue Oct 31, 2019
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 31, 2019
@SomayaB
Copy link
Contributor

SomayaB commented Oct 31, 2019

@jogold Thanks for working on this!

@mergify mergify bot closed this as completed in #4790 Nov 4, 2019
mergify bot pushed a commit that referenced this issue Nov 4, 2019
@jogold @mergify
feat(custom-resources): implement IGrantable for AwsCustomResource (#…
b840784 
…4790)

* feat(custom-resources): implement IGrantable for AwsCustomResource

Closes #4710

* remove IPrincipal

* doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(custom-resources): implement IGrantable for AwsCustomResource jogold/aws-cdk
4 participants
@eladb @abelmokadem @jogold @SomayaB