Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @aws-cdk/aws-custom-resources to @aws-cdk/custom-resources #483

Closed
eladb opened this issue Aug 2, 2018 · 3 comments · Fixed by #513
Closed

Rename @aws-cdk/aws-custom-resources to @aws-cdk/custom-resources #483

eladb opened this issue Aug 2, 2018 · 3 comments · Fixed by #513

Comments

@eladb
Copy link
Contributor

eladb commented Aug 2, 2018

No description provided.

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 2, 2018

Yes, this is not a service 😁

rix0rrr pushed a commit that referenced this issue Aug 6, 2018
BREAKING: rename '@aws-cdk/aws-custom-resources'
489052c 
Since this package does not correspond to an AWS service,
it should not be named with an 'aws-' prefix.

Fixes #483.
@rix0rrr rix0rrr mentioned this issue Aug 6, 2018
Merged
@RomainMuller
Copy link
Contributor

Is it not? I believe it corresponds to the AWS::CloudFormation::CustomResource which to a certain extend I would regard as a CloudFormation entity in the same regimen as other entities. Quite possibly this should be merged with @aws-cdk/aws-cloudformation, but I think that's about as far as I'd go...

@eladb
Copy link
Contributor Author

eladb commented Aug 7, 2018

Good point @RomainMuller - agreed it should be part of the @aws-cdk/aws-cloudformation L2.

rix0rrr added a commit that referenced this issue Aug 9, 2018
@rix0rrr
BREAKING: remove '@aws-cdk/aws-custom-resources' (#513)
b8ddf16 
Since this package does not correspond to an AWS service,
it should not be named with an 'aws-' prefix.

Fixes #483.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: remove '@aws-cdk/aws-custom-resources' aws/aws-cdk
3 participants
@RomainMuller @rix0rrr @eladb