Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK version 1.16.2 - cdk deploy does not accept stackname #4997

Closed
pputhran opened this issue Nov 13, 2019 · 2 comments · Fixed by #4998
Closed

CDK version 1.16.2 - cdk deploy does not accept stackname #4997

pputhran opened this issue Nov 13, 2019 · 2 comments · Fixed by #4998
Assignees
@eladb
Labels
bug This issue is a bug. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p0

Comments

@pputhran
Copy link

❓ General Issue

The Question

Were there any recent changes related to passing stackname to CDK deploy?

Noticed my CDK deploy started failing since the version was updated to 1.16.2

I am passing a stack name to cdk deploy

cdk deploy ${PERF_TEST_STACK_NAME}

where export PERF_TEST_STACK_NAME=somestackname

but cdk deploy is returning "No stack found matching 'somestackname'. Use "list" to print manifest” and when I do cdk list, it returns PerftestStackAirlineStack

/bin/cdk-app.ts

const STACK_NAME = process.env.PERF_TEST_STACK_NAME
const app = new cdk.App();
new PerftestStackAirlineStack(app, 'PerftestStackAirlineStack', {stackName: STACK_NAME});

This was working before I updated the cdk version (previous working verison was 1.10.x).

Environment

  • CDK CLI Version: 1.16.2 (build 5893301)
  • Module Version: @aws-cdk/core: 1.16.2
  • OS: OSX Mojave
  • Language: Typescript

Other information
@pputhran pputhran added the needs-triage This issue or PR still needs to be triaged. label Nov 13, 2019
@rix0rrr rix0rrr added the bug This issue is a bug. label Nov 13, 2019
@eladb eladb added the p0 label Nov 13, 2019
@eladb
Copy link
Contributor

eladb commented Nov 13, 2019

Acknowledging as a regression. This should have been enabled only under a feature flag for new projects.

@pputhran pputhran changed the title CDK version 1.1.6.2 - cdk deploy does not accept stackname CDK version 1.16.2 - cdk deploy does not accept stackname Nov 13, 2019
eladb pushed a commit that referenced this issue Nov 13, 2019
fix(core): unable to find stack by name using the cli in legacy mode
c231da9 
Legacy mode for #4895 still used the uniquely generated id instead of the stack name as the artifact ID in the cloud assembly. The implications were that even if users were not opted-in to the new behavior (through the feature flag), they could not use the stack name in the CLI because the stack artifact ID was still new.

This fix ensures that if the feature flag is not enabled, the artifact ID itself uses the stack name, hence allowing users to query by stack name as long as they are not opted in to the new behavior.

Fixes #4997
@eladb eladb mentioned this issue Nov 13, 2019
Merged
@eladb eladb added pr/work-in-progress This PR is a draft and needs further work. in-progress This issue is being actively worked on. and removed pr/work-in-progress This PR is a draft and needs further work. labels Nov 13, 2019
@eladb
Copy link
Contributor

eladb commented Nov 13, 2019

Hopefully we'll be able to release this shortly.

@mergify mergify bot closed this as completed in #4998 Nov 13, 2019
mergify bot pushed a commit that referenced this issue Nov 13, 2019
@mergify
fix(core): unable to find stack by name using the cli in legacy mode (#…
26bba19 
…4998)

Legacy mode for #4895 still used the uniquely generated id instead of the stack name as the artifact ID in the cloud assembly. The implications were that even if users were not opted-in to the new behavior (through the feature flag), they could not use the stack name in the CLI because the stack artifact ID was still new.

This fix ensures that if the feature flag is not enabled, the artifact ID itself uses the stack name, hence allowing users to query by stack name as long as they are not opted in to the new behavior.

Fixes #4997
RomainMuller pushed a commit that referenced this issue Nov 13, 2019
@RomainMuller
fix(core): unable to find stack by name using the cli in legacy mode (#…
e9a305c 
…4998)

Legacy mode for #4895 still used the uniquely generated id instead of the stack name as the artifact ID in the cloud assembly. The implications were that even if users were not opted-in to the new behavior (through the feature flag), they could not use the stack name in the CLI because the stack artifact ID was still new.

This fix ensures that if the feature flag is not enabled, the artifact ID itself uses the stack name, hence allowing users to query by stack name as long as they are not opted in to the new behavior.

Fixes #4997
@gustakasn0v gustakasn0v mentioned this issue Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
bug This issue is a bug. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): unable to find stack by name using the cli in legacy mode aws/aws-cdk
3 participants
@rix0rrr @eladb @pputhran