-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move secret rotation to aws-secretsmanager and add aws-secretsmanager-targets #5194
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-secretsmanager
Related to AWS Secrets Manager
feature-request
A feature should be added or improved.
in-progress
This issue is being actively worked on.
Comments
jogold
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 26, 2019
100% agreed. |
jogold
added a commit
to jogold/aws-cdk
that referenced
this issue
Dec 3, 2019
Add support for Redshift clusters, DocumentDB databases and the multi user rotation scheme. Move `SecretRotation` from `aws-rds` to `aws-secretsmanager`. Add resource policy for secrets and use it to prevent deletion of secrets for which rotation is enabled. Update instance class to `t3` in `aws-rds` integration tests (`t2` is being deprecated and Oracle `t2` instances cannot be created anymore). Closes aws#5194 BREAKING CHANGE: `addRotationSingleUser(id: string, options: SecretRotationOptions)` is now `addRotationSingleUser(automaticallyAfter?: Duration)`
jogold
added a commit
to jogold/aws-cdk
that referenced
this issue
Dec 3, 2019
Add support for Redshift clusters, DocumentDB databases and the multi user rotation scheme. Move `SecretRotation` from `aws-rds` to `aws-secretsmanager`. Add resource policy for secrets and use it to prevent deletion of secrets for which rotation is enabled. Update instance class to `t3` in `aws-rds` integration tests (`t2` is being deprecated and Oracle `t2` instances cannot be created anymore). Closes aws#5194 BREAKING CHANGE: `addRotationSingleUser(id: string, options: SecretRotationOptions)` is now `addRotationSingleUser(automaticallyAfter?: Duration)`
jogold
added a commit
to jogold/aws-cdk
that referenced
this issue
Dec 3, 2019
Add support for Redshift clusters, DocumentDB databases and the multi user rotation scheme. Move `SecretRotation` from `aws-rds` to `aws-secretsmanager`. Add resource policy for secrets and use it to prevent deletion of secrets for which rotation is enabled. Update instance class to `t3` in `aws-rds` integration tests (`t2` is being deprecated and Oracle `t2` instances cannot be created anymore). Closes aws#5194 BREAKING CHANGE: `addRotationSingleUser(id: string, options: SecretRotationOptions)` is now `addRotationSingleUser(automaticallyAfter?: Duration)`
SomayaB
added
in-progress
This issue is being actively worked on.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Dec 3, 2019
rix0rrr
pushed a commit
that referenced
this issue
Dec 20, 2019
Add support for Redshift clusters, DocumentDB databases and the multi user rotation scheme. Move `SecretRotation` from `aws-rds` to `aws-secretsmanager`. Add resource policy for secrets and use it to prevent deletion of secrets for which rotation is enabled. Update instance class to `t3` in `aws-rds` integration tests (`t2` is being deprecated and Oracle `t2` instances cannot be created anymore). Closes #5194 BREAKING CHANGE: `addRotationSingleUser(id: string, options: SecretRotationOptions)` is now `addRotationSingleUser(automaticallyAfter?: Duration)`
Can this be used with redshiftserverless? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-secretsmanager
Related to AWS Secrets Manager
feature-request
A feature should be added or improved.
in-progress
This issue is being actively worked on.
AWS Secrets Manager just announced support for Redshift and DocumentDB: https://aws.amazon.com/about-aws/whats-new/2019/11/aws-secrets-manager-easier-rotate-secrets-through-cloudformation/
The
SecretRotation
class is currently located inaws-rds
but should be moved toaws-secretsmanager
.Secret target attachements should be implemented in a separate package
aws-secretsmanager-targets
(integration pattern).Serverless applications should be updated to their latest version which include lambda permissions.
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: