Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CodePipeline variables #5219

Closed
1 of 2 tasks
thomasklinger1234 opened this issue Nov 27, 2019 · 1 comment · Fixed by #5604
Closed
1 of 2 tasks

Add support for CodePipeline variables #5219

thomasklinger1234 opened this issue Nov 27, 2019 · 1 comment · Fixed by #5604
Assignees
@skinny85
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@thomasklinger1234
Copy link

thomasklinger1234 commented Nov 27, 2019 •
edited
Loading

CodePipeline recently introduced variables in stages. CloudFormation support is available.

There should be an extension to CodePipeline stages to allow for variables. In the first place, using it through a property in stages is fine.

In a second stage there could also be an opportunity to construct the reference (#{namespace.variable_key}) through a CDK construct and provide a render() method to get the actual variable as accepted by CodePipeline.

When there are no reasons to not implement is, I would be happy to provide a PR.

Use Case

Extending my current pipelines to use dynamic references (e.g. creating CloudFormation changesets based on git commit id).

Proposed Solution

Extend @aws-cdk/aws-codepipeline/lib/action.ts:: CommonActionProps with the namespace property (optional).

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@thomasklinger1234 thomasklinger1234 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2019
@skinny85 skinny85 self-assigned this Nov 27, 2019
@skinny85 skinny85 added @aws-cdk/aws-codepipeline Related to AWS CodePipeline and removed needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2019
@skinny85
Copy link
Contributor

Thanks for opening the feature request @thomasklinger1234 !

Feel free to take a stab at an implementation PR, I'd be glad to review it :).

Thanks,
Adam

@jgondron jgondron mentioned this issue Dec 6, 2019
Closed
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 9, 2019
jgondron added a commit to ndlib/marble-blueprints that referenced this issue Dec 11, 2019
Add commit info to approvals
ee688fd 
Added commit message and a url to the changes to the approval message in all pipelines based on cloudformation. We'll have to wait a bit until cdk supports the namespace property of actions (aws/aws-cdk#5219) before we can change those.

Reference: https://docs.aws.amazon.com/codepipeline/latest/userguide/reference-variables.html#reference-variables-list
@jgondron jgondron mentioned this issue Dec 11, 2019
Merged
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jan 10, 2020
@skinny85
feat(codepipeline): CodePipeline Variables
e7aff40 
Added support for the CodePipeline Variables feature,
by adding action class-specific interfaces that represent the
collection of variables they emit,
and a readonly property of the action instance that returns that interface.
Plus a class representing the global pipeline variables
with static properties.

Fixes aws#5219
@skinny85 skinny85 mentioned this issue Jan 10, 2020
Merged
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jan 14, 2020
@skinny85
feat(codepipeline): CodePipeline Variables
5208b97 
Added support for the CodePipeline Variables feature,
by adding action class-specific interfaces that represent the
collection of variables they emit,
and a readonly property of the action instance that returns that interface.
Plus a class representing the global pipeline variables
with static properties.

Fixes aws#5219
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jan 14, 2020
@skinny85
feat(codepipeline): CodePipeline Variables
29454c8 
Added support for the CodePipeline Variables feature,
by adding action class-specific interfaces that represent the
collection of variables they emit,
and a readonly property of the action instance that returns that interface.
Plus a class representing the global pipeline variables
with static properties.

Fixes aws#5219
@mergify mergify bot closed this as completed in #5604 Jan 15, 2020
mergify bot added a commit that referenced this issue Jan 15, 2020
@skinny85 @mergify
feat(codepipeline): Pipeline Variables (#5604)
34d3e7d 
* feat(codepipeline): CodePipeline Variables

Added support for the CodePipeline Variables feature,
by adding action class-specific interfaces that represent the
collection of variables they emit,
and a readonly property of the action instance that returns that interface.
Plus a class representing the global pipeline variables
with static properties.

Fixes #5219

* Change the tokens to force a lazy variableExpression().

* Rename the variables interfaces to remove the `I` prefix.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline): Pipeline Variables skinny85/aws-cdk
feat(codepipeline): Add action namespace
3 participants
@skinny85 @SomayaB @thomasklinger1234