Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfnspec): update CloudFormation Resource Specification to v10.0.0 #5302

Closed
2 tasks
pahud opened this issue Dec 5, 2019 · 2 comments · Fixed by #5339
Closed
2 tasks

feat(cfnspec): update CloudFormation Resource Specification to v10.0.0 #5302

pahud opened this issue Dec 5, 2019 · 2 comments · Fixed by #5339
Assignees
@shivlaks
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@pahud
Copy link
Contributor

pahud commented Dec 5, 2019 •
edited
Loading

we got a few features pending on the v10.0.0 spec

Use Case

#5156

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2019
@shivlaks shivlaks self-assigned this Dec 5, 2019
@shivlaks
Copy link
Contributor

shivlaks commented Dec 5, 2019

@pahud - I'm on it!

shivlaks added a commit that referenced this issue Dec 8, 2019
@shivlaks
feat(cloudformation): update Resource Specification to v10.0.0
47fff9e 
Closes #5302
@shivlaks shivlaks mentioned this issue Dec 8, 2019
Merged
@mergify mergify bot closed this as completed in #5339 Dec 8, 2019
mergify bot pushed a commit that referenced this issue Dec 8, 2019
@shivlaks @jogold @mergify
feat(cloudformation): update Resource Specification to v10.0.0 (#5339)
3db8565 
* feat(cloudformation): update Resource Specification to v10.0.0

Closes #5302

* Update packages/@aws-cdk/aws-accessanalyzer/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-accessanalyzer/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-eventschemas/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-eventschemas/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
@pahud
Copy link
Contributor Author

pahud commented Dec 8, 2019

Wow @shivlaks thanks a lot!

ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this issue Dec 17, 2019
@shivlaks @jogold
feat(cloudformation): update Resource Specification to v10.0.0 (aws#5339
32f176d 
)

* feat(cloudformation): update Resource Specification to v10.0.0

Closes aws#5302

* Update packages/@aws-cdk/aws-accessanalyzer/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-accessanalyzer/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-eventschemas/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-eventschemas/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudformation): update Resource Specification to v10.0.0 aws/aws-cdk
2 participants
@pahud @shivlaks