Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] Failed to run eks.ClusterResource if upgrade lambda-layer-kubectl to 2.0.0-beta1 #5328

Closed
walkley opened this issue Dec 6, 2019 · 3 comments
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. p2

Comments

@walkley
Copy link
Contributor

walkley commented Dec 6, 2019

eks.ClusterResource lambda function raise exception if I upgrade lambda-layer-kubectl to 2.0.0-beta1

Reproduction Steps

  1. Upgrade version of lambda-layer-kubectl to 2.0.0-beta1:
    const KUBECTL_APP_VERSION = '2.0.0-beta1';
    
  2. Create EKS Cluster: new eks.Cluster(...) then deploy cdk stack

Error Log

Exception raised in lambda function:
Traceback (most recent call last):
File "/var/task/index.py", line 192, in cfn_send
response = requests.put(responseUrl, data=body, headers=headers)
AttributeError: module 'botocore.vendored.requests' has no attribute 'put'

Environment

  • CLI Version :
  • Framework Version: v1.18.0
  • OS : Linux
  • Language : Typescript

Other

Actually lambda-layer-kubectl is unnecessary in eks.ClusterResource, it's not used by any code in the lambda function, if I remove kubectl layer in eks.ClusterResource and related code in lambda function, it still works fine.

I will submit a PR to fix this issue.


This is 🐛 Bug Report

@walkley walkley added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 6, 2019
@pahud
Copy link
Contributor

pahud commented Dec 7, 2019

Hi @eladb

I believe we should remove the requests from the botocore.vendored.

from botocore.vendored import requests

Removing the vendored version of requests from Botocore
https://aws.amazon.com/tw/blogs/developer/removing-the-vendored-version-of-requests-from-botocore/

Or maybe move to the new provider framework?

@SomayaB SomayaB added @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service in-progress This issue is being actively worked on. labels Dec 9, 2019
@eladb eladb added the p2 label Dec 11, 2019
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Jan 15, 2020
@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

Related to #6279

@eladb eladb added this to the EKS Developer Preview milestone Jun 24, 2020
@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

Should be addressed by #7216

@eladb eladb closed this as completed Jun 24, 2020
@iliapolo iliapolo modified the milestones: EKS Developer Preview, EKS Dev Preview Aug 10, 2020
@iliapolo iliapolo changed the title [EKS] Failed to run eks.ClusterResource if upgrade lambda-layer-kubectl to 2.0.0-beta1 [aws-eks] Failed to run eks.ClusterResource if upgrade lambda-layer-kubectl to 2.0.0-beta1 Aug 16, 2020
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants