-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): remove kubectl layer in cluster-resource #5333
Conversation
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thanks so much for the contribution, but this is shortly (~next week) going to be superseded by a full rewrite of the resource provider. Closing for now. |
Hi @eladb, I am happy to know that "full rewrite of the resource provider" :), actually this PR was the preceding step for another feature regarding deploying Helm charts to EKS(#3748), the development for this feature(#3748) has been finished in my fork. I am curious about the detail of new resource provider, maybe I could rewrite Helm chart deployment based on the new design. |
remove unnecessary dependencies to kubectl layer in EKS cluster-resource.
fix #5328
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license