Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): remove kubectl layer in cluster-resource #5333

Closed
wants to merge 3 commits into from
Closed

fix(eks): remove kubectl layer in cluster-resource #5333

wants to merge 3 commits into from

Conversation

walkley
Copy link
Contributor

@walkley walkley commented Dec 7, 2019

remove unnecessary dependencies to kubectl layer in EKS cluster-resource.

fix #5328

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@walkley walkley requested a review from eladb as a code owner December 7, 2019 12:19
@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2019

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@walkley walkley changed the title remove kubectl layer in cluster-resource fix(eks): remove kubectl layer in cluster-resource Dec 7, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb
Copy link
Contributor

eladb commented Dec 11, 2019

Thanks so much for the contribution, but this is shortly (~next week) going to be superseded by a full rewrite of the resource provider. Closing for now.

@eladb eladb closed this Dec 11, 2019
@walkley
Copy link
Contributor Author

walkley commented Dec 12, 2019

Thanks so much for the contribution, but this is shortly (~next week) going to be superseded by a full rewrite of the resource provider. Closing for now.

Hi @eladb, I am happy to know that "full rewrite of the resource provider" :), actually this PR was the preceding step for another feature regarding deploying Helm charts to EKS(#3748), the development for this feature(#3748) has been finished in my fork. I am curious about the detail of new resource provider, maybe I could rewrite Helm chart deployment based on the new design.

@pahud pahud mentioned this pull request Dec 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-eks] Failed to run eks.ClusterResource if upgrade lambda-layer-kubectl to 2.0.0-beta1
3 participants