Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudformation): update Resource Specification to v10.0.0 #5339

Merged
merged 6 commits into from
Dec 8, 2019
Merged

feat(cloudformation): update Resource Specification to v10.0.0 #5339

merged 6 commits into from
Dec 8, 2019

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Dec 8, 2019

Closes #5302

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks shivlaks requested a review from eladb as a code owner December 8, 2019 03:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 8, 2019
@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jogold
jogold reviewed Dec 8, 2019
View reviewed changes
packages/@aws-cdk/aws-accessanalyzer/package.json Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-accessanalyzer/package.json Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eventschemas/package.json Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-eventschemas/package.json Outdated Show resolved Hide resolved
shivlaks and others added 4 commits December 8, 2019 10:32
@shivlaks @jogold
Update packages/@aws-cdk/aws-accessanalyzer/package.json
d7adbf4 
Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
@shivlaks @jogold
Update packages/@aws-cdk/aws-accessanalyzer/package.json
5b2ef35 
Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
@shivlaks @jogold
Update packages/@aws-cdk/aws-eventschemas/package.json
2ef0a69 
Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
@shivlaks @jogold
Update packages/@aws-cdk/aws-eventschemas/package.json
4d0ab36 
Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
@skinny85 skinny85 mentioned this pull request Dec 8, 2019
Closed
1 task
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3db8565 into master Dec 8, 2019
@mergify mergify bot deleted the shivlaks/cfnspecv10 branch December 8, 2019 21:33
ed-at-work pushed a commit to ed-at-work/aws-cdk that referenced this pull request Dec 17, 2019
@shivlaks @jogold
feat(cloudformation): update Resource Specification to v10.0.0 (aws#5339
32f176d 
)

* feat(cloudformation): update Resource Specification to v10.0.0

Closes aws#5302

* Update packages/@aws-cdk/aws-accessanalyzer/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-accessanalyzer/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-eventschemas/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>

* Update packages/@aws-cdk/aws-eventschemas/package.json

Co-Authored-By: Jonathan Goldwasser <jogold@users.noreply.github.com>
@PatMyron PatMyron mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogold jogold jogold left review comments

@rix0rrr rix0rrr rix0rrr approved these changes

@eladb eladb Awaiting requested review from eladb

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cfnspec): update CloudFormation Resource Specification to v10.0.0
4 participants
@shivlaks @aws-cdk-automation @rix0rrr @jogold