Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable logging for express stepfunctions #5754

Closed
2 tasks
jonny-rimek opened this issue Jan 10, 2020 · 1 comment · Fixed by #6933
Closed
2 tasks

Enable logging for express stepfunctions #5754

jonny-rimek opened this issue Jan 10, 2020 · 1 comment · Fixed by #6933
Assignees
@nija-at
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.

Comments

@jonny-rimek
Copy link

Express stepfunctions work differently than the old ones, the logs are directly written to cloudwatch logs, if enabled. It would be amazing if there was a property on StateMaschineProps to activate logs.

Use Case

For everyone using express stepfunctions and needing observability

Proposed Solution

Add it to the higher level construct

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@jonny-rimek jonny-rimek added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 10, 2020
@SomayaB SomayaB added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Jan 13, 2020
@rix0rrr rix0rrr assigned nija-at and unassigned rix0rrr Jan 23, 2020
@nija-at nija-at mentioned this issue Feb 19, 2020
Closed
@nija-at nija-at changed the title Allow enabling logging for express stepfunctions Enable logging for express stepfunctions Feb 20, 2020
@nija-at
Copy link
Contributor

nija-at commented Feb 20, 2020

This will need to implement the property LoggingConfiguration.

@nija-at nija-at added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Feb 20, 2020
workeitel added a commit to workeitel/aws-cdk that referenced this issue Mar 22, 2020
@workeitel
feat(stepfunctions): Support logging configuration
0f356da 
Fixes aws#5754
@workeitel workeitel mentioned this issue Mar 22, 2020
Merged
workeitel added a commit to workeitel/aws-cdk that referenced this issue Mar 22, 2020
@workeitel
feat(stepfunctions): Support logging configuration
5842aab 
Fixes aws#5754
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Mar 25, 2020
workeitel added a commit to workeitel/aws-cdk that referenced this issue Mar 30, 2020
@workeitel
feat(stepfunctions): Support logging configuration
d472177 
Fixes aws#5754
@mergify mergify bot closed this as completed in #6933 Apr 3, 2020
mergify bot pushed a commit that referenced this issue Apr 3, 2020
@workeitel
feat(stepfunctions): execution history logging options (#6933)
adb6954 
closes #5754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions): execution history logging options workeitel/aws-cdk
4 participants
@rix0rrr @nija-at @SomayaB @jonny-rimek