feat(dynamodb): global tables version 2019.11.21 #5821

jogold · 2020-01-15T21:23:20Z

Add support for global tables version 2019.11.21.

Version 2019.11.21 (current) of global tables enables to dynamically add new
replica tables from a table populated with data. It is more efficient and
consumes less write capacity than version 2017.11.29.

Uses the custom resource provider framework (async) to update the table
(onEvent) and check for replica creation (isComplete).

Tables no longer have to be created in separate "regional" stacks and then
"glued" together with a custom resource as in @aws-cdk/aws-dynamodb-global.
This means that a separate module is no longer justified.

Deprecate @aws-cdk/aws-dynamodb-global: it uses version 2017.11.29 and the API
and custom resource implementation for version 2019.11.21 is much cleaner.

See https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/globaltables.V2.html

Closes #5752
Closes #5489
Closes #5516

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add support for global tables version 2019.11.21. Version 2019.11.21 (current) of global tables enables to dynamically add new replica tables from a table populated with data. It is more efficient and consumes less write capacity than version 2017.11.29. Uses the custom resource provider framework (async) to update the table (`onEvent`) and check for replica creation (`isComplete`). Tables no longer have to be created in separate "regional" stacks and then "glued" together with a custom resource as in `@aws-cdk/aws-dynamodb-global`. This means that a separate module is no longer justified. Deprecate `@aws-cdk/aws-dynamodb-global`: it uses version 2017.11.29 and the API and custom resource implementation for version 2019.11.21 is much cleaner. See https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/globaltables.V2.html Closes aws#5752

aws-cdk-automation · 2020-01-15T21:40:26Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@aws-cdk/aws-dynamodb/lib/table.ts

packages/@aws-cdk/aws-dynamodb/lib/replica-handler/index.ts

aws-cdk-automation · 2020-01-15T22:49:05Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-16T09:06:24Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jogold · 2020-01-16T19:18:35Z

packages/@aws-cdk/aws-dynamodb/lib/replica-handler/index.ts

+  latestSdkInstalled = true;
+}
+
+export async function onEventHandler(event: any): Promise<any> {


@eladb I was not able to use the framework types (AWSCDKAsyncCustomResource namespace) exported in @aws-cdk/custom-resources... any idea why? or how I could use them?

If I export those types in lib/provider-framework/index.ts (export * from './types'), I can use them but then jsii complains when building @aws-cdk/custom-resources because types are extending types defined in @types/aws-lambda

Of course it works by deeply importing (import { IsCompleteResponse, OnEventResponse } from '@aws-cdk/custom-resources/lib/provider-framework/types';), this is OK inside this repo but not a good user experience for users consuming @aws-cdk/custom-resources

aws-cdk-automation · 2020-01-17T16:46:35Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-24T10:02:10Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85 · 2020-01-28T02:09:53Z

I did not have time to look at this last week - @nija-at , it's all yours :).

packages/@aws-cdk/aws-dynamodb/lib/table.ts

jogold · 2020-02-10T12:03:55Z

We can maybe add something here to also close #5516. Looking into this.

aws-cdk-automation · 2020-02-10T12:13:58Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-10T12:24:25Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jogold · 2020-02-11T09:09:15Z

@eladb do we want to expose an array of ITable representing the replica tables (with real CF dependency on the custom resource)? I'm not sure it's useful since you would not be able to consume it in a stack deployed in another region...

eladb · 2020-02-11T09:12:18Z

do we want to expose an array of ITable representing the replica tables

Maybe we can add this later

packages/@aws-cdk/aws-dynamodb/lib/table.ts

packages/@aws-cdk/aws-dynamodb/lib/replica-provider.ts

aws-cdk-automation · 2020-02-11T09:46:31Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-11T09:54:21Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-11T10:29:08Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-02-11T10:29:31Z

Thank you for contributing! Your pull request is now being automatically merged.

aws-cdk-automation · 2020-02-11T11:35:09Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2020-02-11T11:35:31Z

Thank you for contributing! Your pull request is now being automatically merged.

phstc · 2022-01-20T22:04:05Z

@jogold @eladb I'm trying to enable pointInTimeRecovery on the regional tables, and I couldn't find any accessor to access individual tables. regionalArns is protected and globalReplicaCustomResources is private.

I'm wondering if this is by design, for example, if there's any limitation with global tables and global point in time recovery, or if we can expose or even enable it by default if the main table has pointInTimeRecovery: true

skinny85 · 2022-01-20T22:25:35Z

@phstc can you open us a separate issue about this? This PR is over 2 years old, not really a great place for this discussion I feel 🙂.

phstc · 2022-01-20T23:03:33Z

@skinny85 absolutely. Thanks for checking!

#18582

jogold requested a review from skinny85 as a code owner January 15, 2020 21:23

eladb reviewed Jan 15, 2020

View reviewed changes

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved

eladb reviewed Jan 15, 2020

View reviewed changes

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved

eladb reviewed Jan 15, 2020

View reviewed changes

packages/@aws-cdk/aws-dynamodb/lib/replica-handler/index.ts Outdated Show resolved Hide resolved

SomayaB assigned skinny85 Jan 15, 2020

jogold added 3 commits January 15, 2020 23:12

fix test

7b1afe0

extract to private method

028c11e

switch in isComplete

79a6e18

decdk

47eb5ba

Merge branch 'master' into dynamodb-global-v2

af34675

jogold commented Jan 16, 2020

View reviewed changes

jogold added 2 commits January 17, 2020 15:17

Merge branch 'master' into dynamodb-global-v2

01c04e1

region check

4cba718

jogold added 2 commits January 24, 2020 09:37

Merge branch 'master' into dynamodb-global-v2

d462240

types

d9c7b32

skinny85 removed their request for review January 28, 2020 02:10

skinny85 assigned nija-at and unassigned skinny85 Jan 28, 2020

nija-at assigned eladb and unassigned nija-at Feb 4, 2020

This was referenced Feb 6, 2020

DynamoDb Global Table add grant_read/write methods #5516

Closed

New dynamo global table version support #5489

Closed

eladb reviewed Feb 10, 2020

View reviewed changes

packages/@aws-cdk/aws-dynamodb/lib/table.ts Show resolved Hide resolved

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-dynamodb/lib/table.ts Show resolved Hide resolved

jogold added 4 commits February 10, 2020 12:35

Merge branch 'master' into dynamodb-global-v2

14fba1c

replicationRegions

1ac8a98

default to PAY_PER_REQUEST

cd2f458

remove useless PAY_PER_REQUEST in tests

9848c53

jogold added 4 commits February 10, 2020 13:51

monocdk-experiment

d8cf1ac

table status and no updates

c94c8ff

Merge branch 'master' into dynamodb-global-v2

10bfe46

replicationRegions in aws-dynamodb-global

b00c4a7

added @experimental tag to `replicationRegions

2514d8a

eladb reviewed Feb 11, 2020

View reviewed changes

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved

packages/@aws-cdk/aws-dynamodb/lib/replica-provider.ts Show resolved Hide resolved

remove streamSpecification = undefined

89df7d0

eladb approved these changes Feb 11, 2020

View reviewed changes

Merge branch 'master' into dynamodb-global-v2

94192b0

mergify bot merged commit 8c0c2b1 into aws:master Feb 11, 2020

jogold deleted the dynamodb-global-v2 branch February 11, 2020 12:42

arnab mentioned this pull request Jun 15, 2021

(DynamoDB): Enabling ContributorInsights (boolean flag) does not reflect in child/related resources (like GSIs and replication regions) #15080

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dynamodb): global tables version 2019.11.21 #5821

feat(dynamodb): global tables version 2019.11.21 #5821

jogold commented Jan 15, 2020 •

edited

Loading

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 15, 2020

aws-cdk-automation commented Jan 16, 2020

jogold Jan 16, 2020 •

edited

Loading

jogold Jan 19, 2020

jogold Jan 23, 2020 •

edited

Loading

aws-cdk-automation commented Jan 17, 2020

aws-cdk-automation commented Jan 24, 2020

skinny85 commented Jan 28, 2020

jogold commented Feb 10, 2020

aws-cdk-automation commented Feb 10, 2020

aws-cdk-automation commented Feb 10, 2020

jogold commented Feb 11, 2020

eladb commented Feb 11, 2020

aws-cdk-automation commented Feb 11, 2020

aws-cdk-automation commented Feb 11, 2020

aws-cdk-automation commented Feb 11, 2020

mergify bot commented Feb 11, 2020

aws-cdk-automation commented Feb 11, 2020

mergify bot commented Feb 11, 2020

phstc commented Jan 20, 2022

skinny85 commented Jan 20, 2022

phstc commented Jan 20, 2022

feat(dynamodb): global tables version 2019.11.21 #5821

feat(dynamodb): global tables version 2019.11.21 #5821

Conversation

jogold commented Jan 15, 2020 • edited Loading

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 15, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 16, 2020

AWS CodeBuild CI Report

jogold Jan 16, 2020 • edited Loading

Choose a reason for hiding this comment

jogold Jan 19, 2020

Choose a reason for hiding this comment

jogold Jan 23, 2020 • edited Loading

Choose a reason for hiding this comment

aws-cdk-automation commented Jan 17, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 24, 2020

AWS CodeBuild CI Report

skinny85 commented Jan 28, 2020

jogold commented Feb 10, 2020

aws-cdk-automation commented Feb 10, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 10, 2020

AWS CodeBuild CI Report

jogold commented Feb 11, 2020

eladb commented Feb 11, 2020

aws-cdk-automation commented Feb 11, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 11, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 11, 2020

AWS CodeBuild CI Report

mergify bot commented Feb 11, 2020

aws-cdk-automation commented Feb 11, 2020

AWS CodeBuild CI Report

mergify bot commented Feb 11, 2020

phstc commented Jan 20, 2022

skinny85 commented Jan 20, 2022

phstc commented Jan 20, 2022

jogold commented Jan 15, 2020 •

edited

Loading

jogold Jan 16, 2020 •

edited

Loading

jogold Jan 23, 2020 •

edited

Loading