Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between Clouformation & cdk elasticsearch CfnDomain #6158

Closed
salam-seek opened this issue Feb 7, 2020 · 2 comments · Fixed by #6434
Closed

Differences between Clouformation & cdk elasticsearch CfnDomain #6158

salam-seek opened this issue Feb 7, 2020 · 2 comments · Fixed by #6434
Assignees
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service bug This issue is a bug. in-progress This issue is being actively worked on. p1

Comments

@salam-seek
Copy link

salam-seek commented Feb 7, 2020

Hi 👋

I'm trying to add an update policy to my elasticsearch cfnDomain in order to add the UpgradeElasticsearchVersion option as per the following documentation : https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticsearch-domain.html#cfn-elasticsearch-domain-elasticsearchversion & https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatepolicy.html#cfn-attributes-updatepolicy-upgradeelasticsearchversion to enable smoother upgrades for version in my cluster via

"UpdatePolicy" : {
  "EnableVersionUpgrade" : Boolean
}

however, it seems that this option is not part of the @aws-cdk/aws-elasticsearch.CfnDomain.cfnOptions.updatePolicy

Reproduction Steps

var es = new elasticsearch.CfnDomain(scope, id, esProps)
es.cfnOptions.updatePolicy.EnableVersionUpgrade // << this property is not defined

Environment

  • CDK Version : 1.22.0 (build 309ac1b)
  • OS : MacOS
  • Language : Typescript

This is 🐛 Bug Report

@salam-seek salam-seek added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 7, 2020
@SomayaB SomayaB added the @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service label Feb 7, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed effort/small Small work item – less than a day of effort labels Feb 24, 2020
@iliapolo
Copy link
Contributor

Hi @salam-seek

Thanks for reporting this. Looks like we are indeed missing this specific update policy.

Stay tuned for the fix :)

P.S: If you feel you want to take a stab at contributing a fix here, you are more than welcome. We will of course provide support and guidance.

@iliapolo
Copy link
Contributor

For self reference, we need to add this policy to the CfnUpdatePolicy interface:

enableVersionUpgrade?: boolean;

chrisb92 pushed a commit to chrisb92/aws-cdk that referenced this issue Feb 25, 2020
When creating an Elasticsearch instance in the CDK, you are unable to
specify how the instance should be upgraded. This functionality is
present in CloudFormation, however it was missed in the CDK.

This fix adds the `enableVersionUpgrade` property to the CfnUpdatePolicy
interface.

Fixes: aws#6158
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2020
@mergify mergify bot closed this as completed in #6434 Feb 26, 2020
mergify bot added a commit that referenced this issue Feb 26, 2020
When creating an Elasticsearch instance in the CDK, you are unable to
specify how the instance should be upgraded. This functionality is
present in CloudFormation, however it was missed in the CDK.

This fix adds the `enableVersionUpgrade` property to the CfnUpdatePolicy
interface.

Fixes: #6158

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service bug This issue is a bug. in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants