Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSync: support for API key configuration #6246

Closed
1 of 2 tasks
duarten opened this issue Feb 12, 2020 · 0 comments · Fixed by #6260
Closed
1 of 2 tasks

AppSync: support for API key configuration #6246

duarten opened this issue Feb 12, 2020 · 0 comments · Fixed by #6260
Assignees
@MrArnoldPalmer
Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.

Comments

@duarten
Copy link
Contributor

duarten commented Feb 12, 2020

By default, the AppSync L2 constructs use API key authorization, but it doesn't allow configuring the API key.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@duarten duarten added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 12, 2020
duarten added a commit to duarten/aws-cdk that referenced this issue Feb 13, 2020
@duarten
feat(appsync): allow configuring API key authorization mode
5084369 
By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes aws#6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>
duarten added a commit to duarten/aws-cdk that referenced this issue Feb 13, 2020
@duarten
feat(appsync): allow configuring API key authorization mode
7bc92cd 
By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes aws#6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@duarten duarten mentioned this issue Feb 13, 2020
Merged
duarten added a commit to duarten/aws-cdk that referenced this issue Feb 13, 2020
@duarten
feat(appsync): allow configuring API key authorization mode
8db2d68 
By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes aws#6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>
duarten added a commit to duarten/aws-cdk that referenced this issue Feb 13, 2020
@duarten
feat(appsync): allow configuring API key authorization mode
9d64b41 
By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes aws#6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@SomayaB SomayaB added the @aws-cdk/aws-appsync Related to AWS AppSync label Feb 13, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Feb 13, 2020
duarten added a commit to duarten/aws-cdk that referenced this issue Feb 19, 2020
@duarten
feat(appsync): allow configuring API key authorization mode
a5bc1c1 
By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes aws#6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>
duarten added a commit to duarten/aws-cdk that referenced this issue Feb 22, 2020
@duarten
feat(appsync): allow configuring API key authorization mode
9fccccf 
By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes aws#6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>
@mergify mergify bot closed this as completed in #6260 Feb 25, 2020
mergify bot added a commit that referenced this issue Feb 25, 2020
@duarten @mergify
feat(appsync): extend authorization configuration (#6260)
948881a 
* feat(appsync): allow configuring API key authorization mode

By default, the AppSync L2 constructs use API key authorization, but it
doesn't allow configuring the API key.

Fix that by allowing a default authorization mode to be specified.
Currently, the supported modes are Cognito user pools and API keys. When
specifying API key authorization, allow configuring it.

BREAKING CHANGE:
    Configuration the user pool authorization is now done through the
    authorizationConfig property. This allows us to specify a default
    authorization mode out of the supported ones, currently limited to
    Cognito user pools and API keys.

Fixes #6246

Signed-off-by: Duarte Nunes <duarte@uma.ni>

* feat(appsync): allow specifying additional authorization modes

Currently the AppSync L2 constructs don't provide a way to configure
additional authorization modes. Add the ability to specify additional
authorization modes, currently limited to Cognito user pools and API
keys.

Fixes #6247

Signed-off-by: Duarte Nunes <duarte@uma.ni>

* test(integ.graphql): test cognito and api key authorization

Test using cognito user pools as the default authorization mode and an
api key as the additional mode.

Signed-off-by: Duarte Nunes <duarte@uma.ni>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
@aws-cdk/aws-appsync Related to AWS AppSync feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(appsync): extend authorization configuration duarten/aws-cdk
3 participants
@duarten @MrArnoldPalmer @SomayaB