Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI might skip deployments incorrectly #6582

Closed
rix0rrr opened this issue Mar 4, 2020 · 0 comments
Closed

CLI might skip deployments incorrectly #6582

rix0rrr opened this issue Mar 4, 2020 · 0 comments
Assignees
@shivlaks
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 4, 2020

Found at least one situation (during bootstrapping) where the stack creation failed, stack ended up in ROLLBACK_COMPLETE (which is an unrecoverable situation) but since CloudFormation still responded with the template that we attempted to deploy the CLI thinks the deployment succeeded (Reported here: #6581)

Fix for this particular instance: check stack state before checking the template.

But more generally, I think we should not do this optimization.

  • Assumptions break in the face of CFN parameters
  • Assumptions break in the face of side effectful updates (template uses SSM Parameters, SecretsManager secrets).

This is 🐛 Bug Report
@rix0rrr rix0rrr added bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2020
@rix0rrr rix0rrr mentioned this issue Mar 4, 2020
Closed
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Mar 4, 2020
@shivlaks shivlaks added the p1 label Mar 11, 2020
rix0rrr added a commit that referenced this issue Jun 22, 2020
@rix0rrr
fix(cli): cannot change policies or trust after initial bootstrap
8778309 
Our nested stack deployment optimizer only used to look at template
differences in order to be able to skip deployments. This has been
enhanced over time, but stack parameters were still not included
in the evaluation.

The new bootstrapping experience relies heavily on parameters to
configure important aspects such as policies and trust. However,
due to the stack deployment skipping, you would not be able to
reconfigure trust or policies after the initial deployment.

Now takes parameters into account as well.

Relates to #8571, relates to #6582, fixes #6581.
@rix0rrr rix0rrr mentioned this issue Jun 22, 2020
Merged
mergify bot pushed a commit that referenced this issue Jun 24, 2020
@rix0rrr
fix(cli): cannot change policies or trust after initial bootstrap (#8677
6e6b23e 
)

Our nested stack deployment optimizer only used to look at template
differences in order to be able to skip deployments. This has been
enhanced over time, but stack parameters were still not included
in the evaluation.

The new bootstrapping experience relies heavily on parameters to
configure important aspects such as policies and trust. However,
due to the stack deployment skipping, you would not be able to
reconfigure trust or policies after the initial deployment.

Now takes parameters into account as well.

Relates to #8571, relates to #6582, fixes #6581.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@shivlaks shivlaks added the effort/small Small work item – less than a day of effort label Aug 7, 2020
@rix0rrr rix0rrr closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rix0rrr @SomayaB @shivlaks