Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how --plugin works, features, and how/why to implement custom plugins #717

Closed
0xdevalias opened this issue Sep 15, 2018 · 5 comments · Fixed by #733
Closed

Document how --plugin works, features, and how/why to implement custom plugins #717

0xdevalias opened this issue Sep 15, 2018 · 5 comments · Fixed by #733
Assignees

Comments

@0xdevalias
Copy link
Contributor

I noticed that the CDK CLI help makes reference to a --plugin option, but beyond this description, couldn't find much more documentation about it:

--plugin, -p         Name or path of a node package that extend the CDK
                       features. Can be specified multiple times         [array]

When searching the repo, I found the following references:

Based on the contract defined in plugins.ts I can see what a plugin would have to look like, and how it is loaded. When a plugin is initialised it receives an instance of PluginHost, but as best I can tell this only seems to give them access to registerCredentialProviderSource.

So I guess my question at the moment is: is that all a plugin can do? Is it able to get access to/add/modify other things at the moment (or in the future will it be able to?)

@0xdevalias 0xdevalias changed the title Document how does --plugin works, features, and how/why to implement custom plugins Document how --plugin works, features, and how/why to implement custom plugins Sep 15, 2018
@eladb
Copy link
Contributor

eladb commented Sep 16, 2018

Yes, at the moment, the toolkit can only be extended around credential providers, but we are open to requests for other extensibility points. @Doug-AWS @RomainMuller, could you please add a little doc section on toolkit plugins in the tools topic?

@RomainMuller
Copy link
Contributor

I'm looking into writing some basic documentation for the existing functionality (as well as hinting that we're happy to add more as the needs arise).

@RomainMuller RomainMuller self-assigned this Sep 17, 2018
RomainMuller added a commit that referenced this issue Sep 17, 2018
Added basic documentation for the Plugins mechanism and surface it offers
in the `Tools` section of the documentation.

Fixes #717
RomainMuller added a commit that referenced this issue Sep 17, 2018
Added basic documentation for the Plugins mechanism and surface it offers
in the `Tools` section of the documentation.

Fixes #717
@0xdevalias
Copy link
Contributor Author

Doco looks great! Much clearer. Thanks! :)

@kcwinner
Copy link

Any roadmap for additional plugin support? Working on something that would be nice to hook in. I can can just write an external package for javascript but would be cooler with more native support.

@rrrix
Copy link

rrrix commented May 21, 2020

Hi @RomainMuller, I think this got lost in the ether somewhere. :( Maybe when the docs moved from this repository to github.com/awsdocs/aws-cdk-guide?

I don't see any documentation related to Plugins on the "main" CDK tools page: https://docs.aws.amazon.com/cdk/latest/guide/tools.html

Nor in the related GitHub repo: https://github.com/awsdocs/aws-cdk-guide/blob/master/doc_source/tools.md

A search for "plugin" on the CDK Docs site returns only the single mention on the Tools page for the CLI argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants