Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createNamingScheme not documented #7527

Closed
rittneje opened this issue Apr 22, 2020 · 0 comments · Fixed by #7840
Closed

createNamingScheme not documented #7527

rittneje opened this issue Apr 22, 2020 · 0 comments · Fixed by #7840
Assignees
@eladb
Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p2

Comments

@rittneje
Copy link

https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_core.Stack.html#rename-wbr-logical-wbr-idoldid-newid

aws-cdk/packages/@aws-cdk/core/lib/stack.ts

Lines 320 to 321 in 986e281

* To modify the naming scheme strategy, extend the `Stack` class and
* override the `createNamingScheme` method.

The documentation references the ability to override the createNamingScheme method, but this method does not appear to be documented anywhere.

This is a 📕 documentation issue
@rittneje rittneje added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 22, 2020
@SomayaB SomayaB added documentation This is a problem with documentation. @aws-cdk/core Related to core CDK functionality labels Apr 23, 2020
eladb pushed a commit that referenced this issue May 7, 2020
fix(core): docs refer to "createNamingScheme" which was renamed to "a…
dacff6f 
…llocateLogicalId"

Fixes #7527
@eladb eladb mentioned this issue May 7, 2020
Merged
@eladb eladb added in-progress This issue is being actively worked on. bug This issue is a bug. p2 effort/small Small work item – less than a day of effort and removed feature-request A feature should be added or improved. labels May 7, 2020
eladb pushed a commit that referenced this issue May 7, 2020
fix(core): docs refer to "createNamingScheme" which was renamed to "a…
d79595d 
…llocateLogicalId" (#7840)

Fixes #7527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/core Related to core CDK functionality bug This issue is a bug. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): docs refer to "createNamingScheme" which was renamed to "allocateLogicalId" aws/aws-cdk
3 participants
@eladb @SomayaB @rittneje