Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apigatewayv2 HTTP API to support custom domain name #7847

Closed
1 of 2 tasks
pahud opened this issue May 7, 2020 · 0 comments · Fixed by #8027
Closed
1 of 2 tasks

apigatewayv2 HTTP API to support custom domain name #7847

pahud opened this issue May 7, 2020 · 0 comments · Fixed by #8027
Assignees
@nija-at
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@pahud
Copy link
Contributor

pahud commented May 7, 2020

Now that we have the initial L2 support, let's add the custom domain support for it.

Use Case

To have custom domain name as well as ACM support just like the restapi

Proposed Solution

We probably can implement this way just like the restapi

aws-cdk/packages/@aws-cdk/aws-apigateway/lib/restapi.ts

Lines 312 to 321 in 87860ca

public addDomainName(id: string, options: DomainNameOptions): DomainName {
const domainName = new DomainName(this, id, {
...options,
mapping: this,
});
if (!this._domainName) {
this._domainName = domainName;
}
return domainName;
}

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2020
@SomayaB SomayaB added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label May 11, 2020
@nija-at nija-at added the effort/medium Medium work item – several days of effort label May 12, 2020
@pahud pahud mentioned this issue May 16, 2020
Merged
4 tasks
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels May 18, 2020
@mergify mergify bot closed this as completed in #8027 Jul 6, 2020
mergify bot pushed a commit that referenced this issue Jul 6, 2020
@pahud
feat(apigatewayv2): http api - custom domain & stage mapping (#8027)
5e43348 
- [x] implementation
- [x] README
- [x] integ test
- [x] 100% unit test coverage

### Commit Message
feat(apigatewayv2): http api - custom domain & stage mapping (#8027)

- Add new `DomainName` and `HttpApiMapping` construct classes and `addDomainName()` method for `HttpApi` resource.
- Add `defaultDomainMapping` construct property for `HttpApi`
- Add `domainMapping` attribute for `addStage`

Closes #7847 

### End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): http api - custom domain & stage mapping
3 participants
@pahud @nija-at @SomayaB