Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextAccountId in the AccessLogField returns invalid value #7951

Closed
loganek opened this issue May 13, 2020 · 0 comments · Fixed by #7952
Closed

contextAccountId in the AccessLogField returns invalid value #7951

loganek opened this issue May 13, 2020 · 0 comments · Fixed by #7952
Assignees
@nija-at
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway bug This issue is a bug. in-progress This issue is being actively worked on. p2

Comments

@loganek
Copy link
Contributor

loganek commented May 13, 2020

When calling AccessLogField.contextAccountId(), the function returns request ID path which doesn't seem to be correct - I'd expect the value to return a path to account ID

Reproduction Steps

call AccessLogField.contextAccountId()

Error Log

Expected return value: '$context.identity.accountId'
Actual return value: '$context.requestId'

Environment

  • Framework Version: CDK master

Other

This is 🐛 Bug Report
@loganek loganek added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 13, 2020
loganek added a commit to loganek/aws-cdk that referenced this issue May 13, 2020
@loganek
fix(apigateway): update value of the contextAccountId in AccessLogField
275c135 
Fixes aws#7951
@loganek loganek mentioned this issue May 13, 2020
Merged
@SomayaB SomayaB added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label May 15, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label May 15, 2020
@nija-at nija-at added p2 and removed needs-triage This issue or PR still needs to be triaged. labels May 20, 2020
@mergify mergify bot closed this as completed in #7952 May 20, 2020
mergify bot pushed a commit that referenced this issue May 20, 2020
@loganek
fix(apigateway): contextAccountId in AccessLogField incorrectly resol…
7b89e80 
…ves to requestId

## Commit Message
fix(apigateway): contextAccountId in AccessLogField incorrectly resolves to requestId (#7952)

fixes #7951
## End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
karupanerura pushed a commit to karupanerura/aws-cdk that referenced this issue May 22, 2020
@loganek @karupanerura
fix(apigateway): contextAccountId in AccessLogField incorrectly resol…
fa84dbd 
…ves to requestId

## Commit Message
fix(apigateway): contextAccountId in AccessLogField incorrectly resolves to requestId (aws#7952)

fixes aws#7951
## End Commit Message

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway bug This issue is a bug. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
3 participants
@loganek @nija-at @SomayaB