-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws-eks] fargate profile issue in aws-auth config map #7981
Labels
Comments
eduardomourar
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
May 14, 2020
Can you please paste your entire CDK app (the relevant portion). I am not sure I understand your workflow. |
Waiting for a response. Closing for now. |
Please, reopen this issue because it is quite important. Relevant code can be found here: https://play-with-cdk.com?s=81c92ad7d69044732f052b8f9a76d3ef |
eladb
pushed a commit
that referenced
this issue
Jun 9, 2020
When a Fargate Profile is added to the cluster, we need to make sure the aws-auth config map is updated from within the CDK app. EKS will do that behind the scenes if it's not done manually, but this means that it would be an out-of-band update of the config map and will be overridden by the CDK if the config map is updated manually. Fixes #7981 BREAKING CHANGE: `cluster.awsAuth` can now return `undefined` if the cluster is not kubectl-enabled. This ensures that users take into account the fact that the cluster may not support aws-auth updates. In most cases, it's sufficient to just use this syntax `cluster.awsAuth?.addxxx` to conditionally update aws-auth.
mergify bot
pushed a commit
that referenced
this issue
Jun 9, 2020
When a Fargate Profile is added to the cluster, we need to make sure the aws-auth config map is updated from within the CDK app. EKS will do that behind the scenes if it's not done manually, but this means that it would be an out-of-band update of the config map and will be overridden by the CDK if the config map is updated manually. Fixes #7981 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
iliapolo
changed the title
EKS fargate profile issue in aws-auth config map
[aws-eks] fargate profile issue in aws-auth config map
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Whenever you use
awsAuth.addRoleMapping()
, the aws-auth config map is being replaced instead of appended within the EKS cluster.Reproduction Steps
kubectl edit cm aws-auth -n kube-system -o yaml
:Error Log
Environment
Other
Workaround:
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: