-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json Schema doesn't support additionalProperties as expected #8069
Comments
Re-classifying this as a bug. |
Any reason why was supporting JsonSchema as additionalProperties removed in september 2019? See: #3997 |
@nikolajwestergaard yes definitely important for defining dictionaries and we need support for that right now. @nija-at any update on when this will get worked on? |
…Schema type (#8848) As per: https://json-schema.org/understanding-json-schema/reference/object.html, the additionalProperties can be boolean or JsonSchema. JsonSchema was previously supported by APIGateway but It was removed for some reason here: 73a1de1. fixes #8069 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…Schema type (aws#8848) As per: https://json-schema.org/understanding-json-schema/reference/object.html, the additionalProperties can be boolean or JsonSchema. JsonSchema was previously supported by APIGateway but It was removed for some reason here: aws@73a1de1. fixes aws#8069 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The definition of additional properties is:
The additionalProperties keyword is used to control the handling of extra stuff, that is, properties whose names are not listed in the properties keyword. By default any additional properties are allowed.
The additionalProperties keyword may be either a boolean or an object. If additionalProperties is a boolean and set to false, no additional properties will be allowed.
If additionalProperties is an object, that object is a schema that will be used to validate any additional properties not listed in properties.
Reference: https://json-schema.org/understanding-json-schema/reference/object.html#properties
When I try to use it as described above:
I get the following error
Code reference:
aws-cdk/packages/@aws-cdk/aws-apigateway/lib/json-schema.ts
Line 66 in 613df1b
The text was updated successfully, but these errors were encountered: