Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment is not updated when OpenAPI definition is updated #8159

Closed
nija-at opened this issue May 22, 2020 · 0 comments · Fixed by #8207
Closed

deployment is not updated when OpenAPI definition is updated #8159

nija-at opened this issue May 22, 2020 · 0 comments · Fixed by #8207
Assignees
@nija-at
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway bug This issue is a bug. p2

Comments

@nija-at
Copy link
Contributor

nija-at commented May 22, 2020

SpecRestApi.

Likely because we don't register OpenAPI definition change into the logicalId calculation of the Deployment -

aws-cdk/packages/@aws-cdk/aws-apigateway/lib/deployment.ts

Line 90 in 8b19453

public addToLogicalId(data: any) {

This is 🐛 Bug Report
@nija-at nija-at added bug This issue is a bug. p2 @aws-cdk/aws-apigateway Related to Amazon API Gateway labels May 22, 2020
@nija-at nija-at self-assigned this May 22, 2020
nija-at pushed a commit that referenced this issue May 26, 2020
fix(apigateway): deployment is not updated when OpenAPI definition is…
1705bf0 
… updated

fixes #8159
@nija-at nija-at mentioned this issue May 26, 2020
Merged
@mergify mergify bot closed this as completed in #8207 May 29, 2020
mergify bot pushed a commit that referenced this issue May 29, 2020
fix(apigateway): deployment is not updated when OpenAPI definition is…
d28c947 
… updated (#8207)


fixes #8159 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway bug This issue is a bug. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(apigateway): deployment is not updated when OpenAPI definition is updated aws/aws-cdk
1 participant
@nija-at