Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite Alarm support on CDK #8462

Closed
1 of 2 tasks
SeekerWing opened this issue Jun 10, 2020 · 0 comments · Fixed by #8498
Closed
1 of 2 tasks

Composite Alarm support on CDK #8462

SeekerWing opened this issue Jun 10, 2020 · 0 comments · Fixed by #8498
Assignees
@rix0rrr
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@SeekerWing
Copy link
Contributor

SeekerWing commented Jun 10, 2020 •
edited
Loading

Use Case

we do not want to associate alarm action with each CW alarm. instead more commonly associate alarms with a group of CW Alarms joined by logical operators.

Proposed Solution

CW supports AND, OR and NOT operators and operands enclosed in ALARM, OK, INSUFFICIENT_DATA, TRUE, FALSE.

my thought process is to define an expression class, this would be implemented by binaryExpression, unaryExpression; binaryExpression would be further implemented by AndExpression and OrExpression; unaryExpression would be further implemented by NotExpression, TrueExpression and FalseExpression.

The constructors for the Expressions will accept an Alarm object and a State object to for an operand.

this class hierarchy will allow user to build valid composite alarm expressions.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@SeekerWing SeekerWing added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 10, 2020
@SeekerWing SeekerWing mentioned this issue Jun 11, 2020
Merged
@SomayaB SomayaB added @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch in-progress This issue is being actively worked on. labels Jun 11, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Jun 11, 2020
@rix0rrr rix0rrr added the effort/medium Medium work item – several days of effort label Jun 16, 2020
@mergify mergify bot closed this as completed in #8498 Jun 22, 2020
mergify bot pushed a commit that referenced this issue Jun 22, 2020
@SeekerWing
feat(cloudwatch): CompositeAlarm (#8498)
1e6d293 
* fix #8462
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): CompositeAlarm SeekerWing/aws-cdk
3 participants
@rix0rrr @SeekerWing @SomayaB