Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Show Docker build output for assets #8956

Closed
2 tasks
hoegertn opened this issue Jul 8, 2020 · 0 comments · Fixed by #8975
Closed
2 tasks

[core] Show Docker build output for assets #8956

hoegertn opened this issue Jul 8, 2020 · 0 comments · Fixed by #8975
Assignees
@eladb
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@hoegertn
Copy link
Contributor

hoegertn commented Jul 8, 2020

Would it be possible to show the output of the Docker build when generating assets?

  1. It would be great to see what exactly is going on
  2. Currently, there is a long "silence" when building so you don't know if it is still doing sth.

@jogold

Proposed Solution

Show Docker build output during synth/deploy

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@hoegertn hoegertn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 8, 2020
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Jul 8, 2020
@jogold jogold mentioned this issue Jul 9, 2020
Closed
2 tasks
jogold added a commit to jogold/aws-cdk that referenced this issue Jul 9, 2020
@jogold
feat(core): show output during asset bundling
2e0146f 
Show Docker outpout during asset bundling.

Closes aws#8956
@jogold jogold mentioned this issue Jul 9, 2020
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 9, 2020
@mergify mergify bot closed this as completed in #8975 Jul 10, 2020
mergify bot pushed a commit that referenced this issue Jul 10, 2020
@jogold
chore(core): show output during asset bundling (#8975)
2386faa 
Show Docker output during asset bundling.

Closes #8956


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): show output during asset bundling jogold/aws-cdk
3 participants
@eladb @hoegertn @SomayaB