[@aws-cdk/pipelines] Incorrect CodeBuild image used in default synth action

[justin8]

When creating a CDK pipeline the default CodeBuild image in use is the old 1.0 one; 4.0 is the latest and specifying it manually allows the pipeline to build successfully. The issue is the 1.0 build image has an older version of node that is no longer supported by ts-jest.

Reproduction Steps

Follow the readme for aws-cdk/pipelines and create a single s3 bucket in the target stack

To resolve the error, change the following on the synthAction:

environment: { buildImage: codebuild.LinuxBuildImage.STANDARD_4_0 },

Error Log

During the codebuild phase right after the source stage I get the following error:

error ts-jest@26.1.2: The engine "node" is incompatible with this module. Expected version ">= 10.21.0". Got "10.19.0"

Environment

• CLI Version: 1.51
• Framework Version: 1.51
• Node.js Version: v12.13.1
• OS : MacOS
• Language (Version): Typescript

Other

---

This is 🐛 Bug Report

[ericzbeard]

@justin8 Is this causing the stack to fail? I don't see any errors when I test it.

[justin8]

Yes, it causes the synthesis stage of the pipeline to fail. Here is a repo that shows a repro. deploy it, push the repo to the created CodeCommit repo and click release in CodePipeline to reproduce the issue: https://github.com/justin8/cdk-pipeline-bug

Uncommenting the environment line in the file will resolve the issue as the build env will use the newer build images. Since the 1.0 images are no longer even listed in the CodeBuild docs perhaps we should be defaulting to at least a more modern/up-to-date image here anyway?

The first commit is the init of the repo, second one shows 100% of the changes required to make it fail; essentially just the exact example from the CDK pipelines sub-package