-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cloudfront] Update Suported Security Protocol Enum #9212
Labels
@aws-cdk/aws-cloudfront
Related to Amazon CloudFront
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
in-progress
This issue is being actively worked on.
p1
Comments
This also needs to be updated: aws-cdk/packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts Lines 805 to 811 in 345389f
Btw it blocks users from using a policy not yet included in the CDK code. |
mergify bot
pushed a commit
that referenced
this issue
Aug 19, 2020
…1_2_2019 as a default version (#9738) Closes #9212 I believe that official CloudFormation docs and AWS Console are out of sync. ### [CloudFormation Docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-viewercertificate.html#cfn-cloudfront-distribution-viewercertificate-minimumprotocolversion):  ### AWS Console:  https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua
pushed a commit
to misterjoshua/aws-cdk
that referenced
this issue
Aug 19, 2020
…1_2_2019 as a default version (aws#9738) Closes aws#9212 I believe that official CloudFormation docs and AWS Console are out of sync. ### [CloudFormation Docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-viewercertificate.html#cfn-cloudfront-distribution-viewercertificate-minimumprotocolversion):  ### AWS Console:  https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-cloudfront
Related to Amazon CloudFront
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
in-progress
This issue is being actively worked on.
p1
Recently the List of Supported Security Protocols got extended. Please follow https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html#secure-connections-supported-ciphers and update this enum:
Use Case
Cloudfront setup.
Proposed Solution
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: