-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[synthetics] support runConfig properties #9300
[synthetics] support runConfig properties #9300
Comments
We are unassigning and marking this issue as p2, which means that we are unable to work on this immediately. |
|
+1, our team would like to use this for environment variables Also we want our canaries to run every minute, this is supported in cfncanary, but not in synthetics.canary We added the cfncanary work around, but it's making it hard to extend our cdk from there. For example, adding alarms is much easier using synthetics.canary as opposed to cfncanary |
+1, our team would like to use this for environment variables |
Add support for canary environment variables that will be threaded to the underlying Lambda function. This allows multiple canaries to use the same source code by extracting configuration to the resource specification. Also makes the README snippets compile since it was hard to tell whether my changes were correct. closes #10515 refer #9300 Co-authored-by: Florian Chazal <florianchazal@gmail.com> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for canary environment variables that will be threaded to the underlying Lambda function. This allows multiple canaries to use the same source code by extracting configuration to the resource specification. Also makes the README snippets compile since it was hard to tell whether my changes were correct. closes aws#10515 refer aws#9300 Co-authored-by: Florian Chazal <florianchazal@gmail.com> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for canary environment variables that will be threaded to the underlying Lambda function. This allows multiple canaries to use the same source code by extracting configuration to the resource specification. Also makes the README snippets compile since it was hard to tell whether my changes were correct. closes aws#10515 refer aws#9300 Co-authored-by: Florian Chazal <florianchazal@gmail.com> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
Issue
AWS Synthetics Canary has an optional
runConfig
property that is currently not supported by the Canary L2. This property exposestimeoutInSeconds
andmemoryInMb
.The difficulty is that
timeoutInSeconds
is required ifrunConfig
is set, so one cannot only specifymemoryInMb
.This does not seem like it should be a hard requirement (i.e. one should be able to set
memoryInMb
withouttimeout
).The requirements for
timeoutInSeconds
are that it is inside the range 3 - 840 seconds* and not greater than the amount specified in theschedule
expression.* yes, this is different than specified in the docs but I tried to set it to be 900 seconds and received the error "Invalid request provided: Run timeout cannot be less than 3 seconds or greater than 840 seconds"
Use Case
The use case for this property is unclear so this issue serves as a platform for discussion on whether it is needed and how to implement.
While the proposed solution is possible, this seems like extra work if the
runConfig
property is largely ignored anyway. And iftimeoutInSeconds
becomes optional, then we no longer need to find a default for the property.Proposed Solution
Add separate optional properties
timeout: cdk.Duration
andmemorySize: cdk.Size
toCanaryProps
.timeout
should default to the minimum of 840 seconds and the amount inexpression
. This would require parsing through the expression string to extract the number/unit and convert to seconds.memorySize
is optional inrunConfig
, so no need to default and it is up to the user to specify a valid amount of memory.This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: