Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add aws-rfdk to version reporting metadata #9336

Closed
1 of 2 tasks
ddneilson opened this issue Jul 29, 2020 · 1 comment
Closed
1 of 2 tasks

[core] Add aws-rfdk to version reporting metadata #9336

ddneilson opened this issue Jul 29, 2020 · 1 comment
Assignees
@eladb
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ddneilson
Copy link
Contributor

The AWS RFDK is a soon-to-be released library for use with the CDK. We have discussed leveraging the CDK's version reporting mechanism with @ccfife and received his blessing to do so.

Use Case

Tracking usage of a new library for use with the CDK.

Proposed Solution

I'll add a package whitelist to core/private/runtime-info.ts. I'll have a PR posted asap.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ddneilson ddneilson added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2020
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Jul 29, 2020
@ddneilson ddneilson mentioned this issue Jul 29, 2020
Merged
mergify bot pushed a commit that referenced this issue Jul 29, 2020
@ddneilson
chore(core): include aws-rfdk in version reporting (#9337)
239e686 
Implements #9336 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@eladb
Copy link
Contributor

eladb commented Aug 4, 2020

Fixed by #9337

@eladb eladb closed this as completed Aug 4, 2020
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@ddneilson
chore(core): include aws-rfdk in version reporting (aws#9337)
daa565e 
Implements aws#9336 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eladb @ddneilson