Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docdb): autoMinorVersionUpgrade property was not set to true by default as stated in the docstring #9505

Merged
merged 2 commits into from
Aug 9, 2020
Merged

fix(docdb): autoMinorVersionUpgrade property was not set to true by default as stated in the docstring #9505

merged 2 commits into from
Aug 9, 2020

Conversation

ddneilson
Copy link
Contributor

@ddneilson ddneilson commented Aug 7, 2020 •
edited by iliapolo
Loading

Fixes #9494

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ryyakobe ryyakobe mentioned this pull request Aug 7, 2020
Closed
@iliapolo iliapolo changed the title fix(docdb): explicitly set autoUpgradeMinorVersion to true by default fix(docdb): autoMinorVersionUpgrade property was not set to true by default as stated in the docstring Aug 9, 2020
iliapolo
iliapolo approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddneilson Thanks for this!

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a236eb8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e878f9c into aws:master Aug 9, 2020
eladb pushed a commit that referenced this pull request Aug 10, 2020
@ddneilson
fix(docdb): autoMinorVersionUpgrade property was not set to true …
03ec384 
…by default as stated in the docstring (#9505)

Fixes #9494

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-docdb] autoMinorVersionUpgrade is not set to true by default
3 participants
@ddneilson @aws-cdk-automation @iliapolo