Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docdb): enabling auto minor version upgrade by default #9495

Closed
wants to merge 1 commit into from

Conversation

ryyakobe
Copy link

@ryyakobe ryyakobe commented Aug 6, 2020

UPDATE: There is another PR solving the same problem with more extensive unit-tests: #9505


Original

autoMinorVersionUpgrade is enabled by default to conform with the documentation.

fixes #9494

Important Note

I didn't add a BREAKING CHANGE to the commit message, although I've changed the unit-tests.
I wasn't sure if I should add it, because this change just fixes a bug, and according to documentation it will just do the right thing.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

autoMinorVersionUpgrade is enabled by default to conform with the documentation.

fixes aws#9494
@ryyakobe ryyakobe force-pushed the ryyakobe/fix-docdb-autoupgrade branch from 11ba6b0 to 0f2cc4f Compare August 6, 2020 21:32
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0f2cc4f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ryyakobe ryyakobe changed the title fix(docdb): enabling auto minor version upgrade by default fixes fix(docdb): enabling auto minor version upgrade by default Aug 6, 2020
@iliapolo
Copy link
Contributor

iliapolo commented Aug 9, 2020

Closing in favor of #9505. Thanks @ryyakobe !

@iliapolo iliapolo closed this Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-docdb] autoMinorVersionUpgrade is not set to true by default
3 participants