Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-cloudfront] Add Geolocation Headers #9523

Closed
2 tasks
NGL321 opened this issue Aug 7, 2020 · 5 comments
Closed
2 tasks

[aws-cloudfront] Add Geolocation Headers #9523

NGL321 opened this issue Aug 7, 2020 · 5 comments
Assignees
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@NGL321
Copy link
Contributor

NGL321 commented Aug 7, 2020

On behalf of: alxgla@

I would like to request the new Cloudfront Geolocation headers be added to the CDK

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@NGL321 NGL321 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Aug 7, 2020
@NGL321
Copy link
Contributor Author

NGL321 commented Aug 7, 2020

I believe that to add these headers we may need to wait for Cloudformation to implement them first. @iliapolo would you agree?

@iliapolo
Copy link
Contributor

iliapolo commented Aug 9, 2020

@NGL321 As I understand, the way to use these headers is through an Origin Request Policy. This is not yet supported by CDK, even though it is by CloudFormation.

Looks like we have a gap here, making @njlynch aware as well.

@iliapolo iliapolo changed the title [Cloudfront] Add Geolocation Headers [aws-cloudfront] Add Geolocation Headers Aug 9, 2020
@iliapolo
Copy link
Contributor

iliapolo commented Aug 9, 2020

Now that i look at it again, it looks like CloudFormation does support passing a policy id, but doesn't support actually creating them. This might a tricky one.

@iliapolo iliapolo added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2020
@iliapolo iliapolo assigned njlynch and unassigned iliapolo Aug 19, 2020
@njlynch
Copy link
Contributor

njlynch commented Oct 12, 2020

Origin Request Policy support was closed out in #9647 for Distribution, and pending #10830 for CloudFrontWebDistribution. Closing this out in favor of those two issues.

@njlynch njlynch closed this as completed Oct 12, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

3 participants