Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloudfront] Origin request policies #9647

Closed
njlynch opened this issue Aug 12, 2020 · 4 comments · Fixed by #10765
Closed

[cloudfront] Origin request policies #9647

njlynch opened this issue Aug 12, 2020 · 4 comments · Fixed by #10765
Assignees
@njlynch
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Milestone
[GA] CloudFront '...

Comments

@njlynch
Copy link
Contributor

njlynch commented Aug 12, 2020 •
edited
Loading

The CloudFormation v16.2.0 spec (pending #9452) introduced origin request policies for behaviors. Origin request policies supersede the existing properties (and new ones) for values that are added to requests to the origin.

See:

This feature request is to add support for both origin request policies in general, and the managed origin request policies as well.

Notes:

  • This is for support for the new Distribution construct; the older CloudFrontWebDistribution is out of scope.

This is a 🚀 Feature Request
@njlynch njlynch added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 12, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Aug 12, 2020
@njlynch njlynch added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 12, 2020
@njlynch njlynch assigned njlynch and unassigned iliapolo Aug 12, 2020
@njlynch njlynch mentioned this issue Aug 12, 2020
Closed
2 tasks
@njlynch njlynch added the in-progress This issue is being actively worked on. label Oct 7, 2020
njlynch added a commit that referenced this issue Oct 7, 2020
@njlynch
feat(cloudfront): support for origin request policies
f604fe6 
Support for the new Origin Request Policy concept in CloudFront, which provides
greater control to users over what values are forwarded to the origin from the
original viewer request.

_Implementation Notes:_
* *Heavily* influenced by #10656, including the same notes on not extending from
  `IResource` and excluding the `lastModifiedTimestamp`.
* Currently marked as a DRAFT, since this PR *requires* #10656;
  origin request policies cannot be used without cache policies.

fixes #9647
@njlynch njlynch mentioned this issue Oct 7, 2020
Merged
njlynch added a commit that referenced this issue Oct 7, 2020
@njlynch
feat(cloudfront): support for origin request policies
005e0b5 
Support for the new Origin Request Policy concept in CloudFront, which provides
greater control to users over what values are forwarded to the origin from the
original viewer request.

_Implementation Notes:_
* *Heavily* influenced by #10656, including the same notes on not extending from
  `IResource` and excluding the `lastModifiedTimestamp`.

fixes #9647
njlynch added a commit that referenced this issue Oct 7, 2020
@njlynch
feat(cloudfront): support for origin request policies
1c4da90 
Support for the new Origin Request Policy concept in CloudFront, which provides
greater control to users over what values are forwarded to the origin from the
original viewer request.

_Implementation Notes:_
* *Heavily* influenced by #10656, including the same notes on not extending from
  `IResource` and excluding the `lastModifiedTimestamp`.

fixes #9647
@mergify mergify bot closed this as completed in #10765 Oct 7, 2020
mergify bot pushed a commit that referenced this issue Oct 7, 2020
@njlynch
feat(cloudfront): support for origin request policies (#10765)
08efc96 
Support for the new Origin Request Policy concept in CloudFront, which provides
greater control to users over what values are forwarded to the origin from the
original viewer request.

_Implementation Notes:_
* *Heavily* influenced by #10656, including the same notes on not extending from
  `IResource` and excluding the `lastModifiedTimestamp`.
* Currently marked as a DRAFT, since this PR *requires* #10656;
  origin request policies cannot be used without cache policies.

fixes #9647

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@njlynch njlynch mentioned this issue Oct 12, 2020
Closed
2 tasks
@mmeylan
Copy link

mmeylan commented Oct 22, 2020 •
edited
Loading

@njlynch Is there a plan to support this for CloudFrontWebDistribution ? Or, as you suggest, is Distribution always the preferred over CloudFrontWebDistribution ? Thinking of moving to Distribution as I need this feature for CORS support.

@njlynch
Copy link
Contributor Author

njlynch commented Oct 22, 2020

@mmeylan - see #10830 for the tracking issue. Please 👍 (or submit a PR!) :D

@mmeylan
Copy link

mmeylan commented Oct 22, 2020

Thanks @njlynch !

Do you have any idea if this origin request policy control is new or if Cloudfront is currently becoming stricter about it ? We didn't have CORS issue with a live deployment so far using Use legacy cache settings, and this morning, we had CORS issue for some of our urls, but not all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
[GA] CloudFront 'Distribution'
Development

Successfully merging a pull request may close this issue.

feat(cloudfront): support for origin request policies aws/aws-cdk
3 participants
@njlynch @iliapolo @mmeylan