Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-appmesh] Add support for virtual gateway #9533

Closed
1 of 2 tasks
otterley opened this issue Aug 7, 2020 · 1 comment · Fixed by #10879
Closed
1 of 2 tasks

[aws-appmesh] Add support for virtual gateway #9533

otterley opened this issue Aug 7, 2020 · 1 comment · Fixed by #10879
Assignees
@skinny85
Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@otterley
Copy link
Contributor

otterley commented Aug 7, 2020

Add support for App Mesh Virtual Gateways (aka AWS::AppMesh::VirtualGateway).

Ideally, it would work identically to the existing addVirtual* methods.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@otterley otterley added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2020
@github-actions github-actions bot added the @aws-cdk/aws-appmesh Related to AWS App Mesh label Aug 7, 2020
@ccfife ccfife mentioned this issue Aug 10, 2020
Open
9 tasks
@MrArnoldPalmer MrArnoldPalmer added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2020
@SomayaB SomayaB assigned skinny85 and unassigned MrArnoldPalmer Aug 20, 2020
@skinny85 skinny85 added the effort/large Large work item – several weeks of effort label Sep 9, 2020
@dfezzie dfezzie mentioned this issue Oct 14, 2020
Merged
3 tasks
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 15, 2020
@mergify mergify bot closed this as completed in #10879 Oct 29, 2020
mergify bot pushed a commit that referenced this issue Oct 29, 2020
feat(appmesh): add Virtual Gateways and Gateway Routes (#10879)
79200e7 
----

This is a draft PR to resolve #9533

Takes an approach for creating protocol specific Gateway Routes as described in #10793 

This is a draft as I am seeking feedback on the implementation and approach for creating per protocol variants of App Mesh Resources.

Before merging:

- [x] Approach for per protocol variants defined
- [x] Update Gateway Listeners to follow the same pattern
- [x] Add more integ tests

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-appmesh Related to AWS App Mesh effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(appmesh): add Virtual Gateways and Gateway Routes dfezzie/aws-cdk
4 participants
@otterley @skinny85 @MrArnoldPalmer @SomayaB