Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Add support for retrieving Hook objects from the template #9713

Closed
6 tasks
skinny85 opened this issue Aug 14, 2020 · 0 comments · Fixed by #10143
Closed
6 tasks

[cfn-include] Add support for retrieving Hook objects from the template #9713

skinny85 opened this issue Aug 14, 2020 · 0 comments · Fixed by #10143
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Milestone
[DevPreview] @aws...

Comments

@skinny85
Copy link
Contributor

skinny85 commented Aug 14, 2020 •
edited
Loading

Similarly like allow retrieving Parameters, Conditions, Resources, and Outputs from the included template today (see the module ReadMe), do the same for Hook objects.

  • Create a new CfnHook class in @aws-cdk/core (make it mutable), according to the CFN docs
  • Add a new method to CfnInclude, public getHook(name: string): CfnHook
  • Create the CfnHook instances in the constructor of CfnInclude
  • Stop rendering the Hooks section of the template unchanged here
  • Update the ReadMe
  • Unit tests
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Aug 14, 2020
@skinny85 skinny85 mentioned this issue Aug 14, 2020
Closed
@skinny85 skinny85 added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Aug 14, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Sep 3, 2020
@skinny85
feat(cfn-include): add support for Hooks
b0259fa 
Add support for creating and retrieving the new Hook
CloudFormation objects used in blue-green deployments.
In order to do that, add new CfnHook and
CfnCodeDeployBlueGreenHook classes to core.

Closes aws#9713
@skinny85 skinny85 mentioned this issue Sep 3, 2020
Merged
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Sep 3, 2020
@skinny85
feat(cfn-include): add support for Hooks
2bb3d53 
Add support for creating and retrieving the new Hook
CloudFormation objects used in blue-green deployments.
In order to do that, add new CfnHook and
CfnCodeDeployBlueGreenHook classes to core.

Closes aws#9713
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 3, 2020
@mergify mergify bot closed this as completed in #10143 Sep 4, 2020
mergify bot pushed a commit that referenced this issue Sep 4, 2020
@skinny85
feat(cfn-include): add support for Hooks (#10143)
4de68c0 
Add support for creating and retrieving the new Hook
CloudFormation objects used in blue-green deployments.
In order to do that, add new CfnHook and
CfnCodeDeployBlueGreenHook classes to core.

Closes #9713

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

feat(cfn-include): add support for Hooks skinny85/aws-cdk
2 participants
@skinny85 @SomayaB