Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Implement L1 to L2 transition for S3 Bucket #9719

Closed
skinny85 opened this issue Aug 14, 2020 · 1 comment
Closed

[cfn-include] Implement L1 to L2 transition for S3 Bucket #9719

skinny85 opened this issue Aug 14, 2020 · 1 comment
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2

Comments

@skinny85
Copy link
Contributor

skinny85 commented Aug 14, 2020 •
edited
Loading

Add a way to go from an L1 CfnBucket to an L2 Bucket.

Rough design:

export class Bucket {
  // ...

  public static fromCfnBucket(cfnBucket: CfnBucket): IBucket;

  // ...
}

Some notes:

  • This might require a new Token type (see the hackathon PoC code for an idea), or using the existing Reference might be good enough.
  • Will also require doing this for KMS' Key (so that we can handle an L1 Bucket that references an L1 Key for encryption).
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Aug 14, 2020
This was referenced Aug 14, 2020
Closed
Closed
@skinny85 skinny85 added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 labels Aug 14, 2020
@skinny85 skinny85 mentioned this issue Aug 14, 2020
Closed
@skinny85 skinny85 mentioned this issue Sep 1, 2020
Closed
@skinny85 skinny85 mentioned this issue May 25, 2021
Merged
mergify bot pushed a commit that referenced this issue Jun 3, 2021
@skinny85
feat(kms): introduce fromCfnKey() method (#14859)
1ff5b9e 
This is part 1 of adding support from converting L1 resources to L2 without making them immutable in the process.
Next phase after this will be adding support for `Bucket.fromCfnBucket()`
(which will use the method from KMS defined here).

Related issues: #9719 #14795 #14809

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@skinny85 @hollanddd
feat(kms): introduce fromCfnKey() method (aws#14859)
a2fee5b 
This is part 1 of adding support from converting L1 resources to L2 without making them immutable in the process.
Next phase after this will be adding support for `Bucket.fromCfnBucket()`
(which will use the method from KMS defined here).

Related issues: aws#9719 aws#14795 aws#14809

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skinny85